only show images as images ;)

Author: laullon

GLFileView.h

@@ -36,6 +36,11 @@
 +(BOOL)isStartDiff:(NSString *)line;
 +(BOOL)isStartBlock:(NSString *)line;
 
++(NSArray *)getFilesNames:(NSString *)line;
++(BOOL)isBinaryFile:(NSString *)line;
++(NSString*)mimeTypeForFileName:(NSString*)file;
++(BOOL)isImage:(NSString*)file;
+
 @property(retain) NSMutableArray *groups;
 @property(retain) NSString *logFormat;
 

GLFileView.m

@@ -181,7 +181,6 @@ - (MGScopeBarGroupSelectionMode)scopeBar:(MGScopeBar *)theScopeBar selectionMode
 
 - (void)scopeBar:(MGScopeBar *)theScopeBar selectedStateChanged:(BOOL)selected forItem:(NSString *)identifier inGroup:(int)groupNumber
 {
-	NSLog(@"startFile=%@ identifier=%@ groupNumber=%d",startFile,identifier,groupNumber);
 	if((groupNumber==0) && (startFile!=identifier)){
 		NSString *path = [NSString stringWithFormat:@"html/views/%@", identifier];
 		NSString *html = [[NSBundle mainBundle] pathForResource:@"index" ofType:@"html" inDirectory:path];
@@ -330,17 +329,19 @@ + (NSString *)parseDiff:(NSString *)txt
 		}else if(inDiff){
 			[res appendString:[NSString stringWithFormat:@"<p>%@</p>",line]];
 			if([self isBinaryFile:line]){
-				NSLog(@"line='%@'",line);
 				[res appendString:@"</td></tr></thead><tbody>"];
 				NSArray *files=[self getFilesNames:line];
-				NSLog(@"files='%@'",files);
 				if(![[files objectAtIndex:0] isAbsolutePath]){
 					[res appendString:[NSString stringWithFormat:@"<tr><td colspan='3'>%@</td></tr>",[files objectAtIndex:0]]];
-					[res appendString:[NSString stringWithFormat:@"<tr><td colspan='3'><img src='GitX://{SHA}:/prev/%@'/></td></tr>",[files objectAtIndex:0]]];
+					if([GLFileView isImage:[files objectAtIndex:0]]){
+						[res appendString:[NSString stringWithFormat:@"<tr><td colspan='3'><img src='GitX://{SHA}:/prev/%@'/></td></tr>",[files objectAtIndex:0]]];
+					}
 				}
 				if(![[files objectAtIndex:1] isAbsolutePath]){
 					[res appendString:[NSString stringWithFormat:@"<tr><td colspan='3'>%@</td></tr>",[files objectAtIndex:1]]];
-					[res appendString:[NSString stringWithFormat:@"<tr><td colspan='3'><img src='GitX://{SHA}/%@'/></td></tr>",[files objectAtIndex:1]]];
+					if([GLFileView isImage:[files objectAtIndex:1]]){
+						[res appendString:[NSString stringWithFormat:@"<tr><td colspan='3'><img src='GitX://{SHA}/%@'/></td></tr>",[files objectAtIndex:1]]];
+					}
 				}
 			}
 		}
@@ -361,7 +362,6 @@ +(NSArray *)getFilesNames:(NSString *)line
 {
 	NSString *a;
 	NSString *b;
-	NSLog(@"line='%@'",line);
 	NSScanner *scanner=[NSScanner scannerWithString:line];
 	if([scanner scanString:@"Binary files " intoString:NULL]){
 		[scanner scanUpToString:@" and" intoString:&a];
@@ -374,10 +374,34 @@ +(NSArray *)getFilesNames:(NSString *)line
 	if (![b isAbsolutePath]) {
 		b=[b substringFromIndex:2];
 	}
-
+	
 	return [NSArray arrayWithObjects:a,b,nil];
 }
 
++(NSString*)mimeTypeForFileName:(NSString*)name
+{
+    NSString *mimeType = nil;
+	NSInteger i=[name rangeOfString:@"." options:NSBackwardsSearch].location;
+	if(i!=NSNotFound){
+		NSString *ext=[name substringFromIndex:i+1];
+		CFStringRef UTI = UTTypeCreatePreferredIdentifierForTag(kUTTagClassFilenameExtension, (CFStringRef)ext, NULL);
+		if(UTI){
+			CFStringRef registeredType = UTTypeCopyPreferredTagWithClass(UTI, kUTTagClassMIMEType);
+			if(registeredType){
+				mimeType = NSMakeCollectable(registeredType);
+			}
+			CFRelease(UTI);
+		}
+	}
+    return mimeType;
+}
+
++(BOOL)isImage:(NSString*)file
+{
+	NSString *mimeType=[GLFileView mimeTypeForFileName:file];
+	return (mimeType!=nil) && ([mimeType rangeOfString:@"image/" options:NSCaseInsensitiveSearch].location!=NSNotFound);
+}
+
 +(BOOL)isBinaryFile:(NSString *)line
 {
 	return (([line length]>12) && [[line substringToIndex:12] isEqualToString:@"Binary files"]);