Don't show very long diffs by default.

Author: barrywardell

PBWebCommitController.h

@@ -19,11 +19,13 @@
 
 	NSString* currentSha;
 	NSString* diff;
+	BOOL showLongDiffs;
 }
 
 - (void) changeContentTo: (PBGitCommit *) content;
 - (void) sendKey: (NSString*) key;
 - (void) openFileMerge:(NSString*)file sha:(NSString *)sha sha2:(NSString *)sha2;
+- (void) showLongDiff;
 
 - (void) didLoad;
 // Called when a commit or parent link is clicked.

PBWebCommitController.m

@@ -32,8 +32,14 @@ @implementation PBWebCommitController
 
 @synthesize diff;
 
+- (void) showLongDiff
+{
+	showLongDiffs = TRUE;
+}
+
 - (void) awakeFromNib
 {
+	showLongDiffs = FALSE;
 	startFile = @"history";
 	[super awakeFromNib];
 }
@@ -118,10 +124,16 @@ - (void)commitDetailsLoaded:(NSNotification *)notification
 	[args addObjectsFromArray:parents];
 	[args addObject:currentSha];
 	NSString *d = [repository outputInWorkdirForArguments:args];
-	NSString *diffs = [GLFileView parseDiff:d];
-	
-	NSString *html = [NSString stringWithFormat:@"%@%@<div id='diffs'>%@</div>",header,fileList,diffs];
-	
+	NSString *html;
+	if(showLongDiffs || [d length] < 200000)
+	{
+		showLongDiffs = FALSE;
+		NSString *diffs = [GLFileView parseDiff:d];
+		html = [NSString stringWithFormat:@"%@%@<div id='diffs'>%@</div>",header,fileList,diffs];
+	} else {
+		html = [NSString stringWithFormat:@"%@%@<div id='diffs'><p>This is a very large commit. It may take a long time to load the diff. Click <a href='' onclick='showFullDiff(); return false;'>here</a> to show anyway.</p></div>",header,fileList,currentSha];
+	}
+
 	html = [html stringByReplacingOccurrencesOfString:@"{SHA_PREV}" withString:[NSString stringWithFormat:@"%@^",currentSha]];
 	html = [html stringByReplacingOccurrencesOfString:@"{SHA}" withString:currentSha];
 

html/views/history/history.js

@@ -21,3 +21,7 @@ var showCommit = function(data){
 	$("commit").innerHTML=data;
 }
 
+var showFullDiff = function() {
+    Controller.showLongDiff();
+    Controller.updateView();
+}