Skip to content

Commit 1f88e07

Browse files
tkhill-AWSkellertk
authored andcommitted
Update method name to describe a Get request (awsdocs#7558)
Fix for https://t.corp.amazon.com/V1905732087
1 parent 85cc145 commit 1f88e07

File tree

5 files changed

+21
-6
lines changed

5 files changed

+21
-6
lines changed

javascriptv3/example_code/cross-services/aurora-serverless-app/src/handlers/post-items-handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const postItemsHandler: Handler = {
1616
guide: { StringValue: guide },
1717
status: { StringValue: status },
1818
name: { StringValue: name },
19-
}
19+
};
2020
const command = buildStatementCommand(
2121
`insert into items (iditem, description, guide, status, username, archived)
2222
values ("${uuidv4()}", ":description", ":guide", ":status", ":name", 0)`,

javascriptv3/example_code/cross-services/aurora-serverless-app/src/handlers/put-items-archive-handler.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,14 @@ const putItemsArchiveHandler: Handler = {
99
({ rdsDataClient }) =>
1010
async (req, res) => {
1111
const { itemId } = req.params;
12-
12+
const values = {
13+
itemId: { StringValue: itemId },
14+
};
1315
const command = buildStatementCommand(
14-
`update items\nset archived = 1\nwhere iditem = "${itemId}"`,
16+
`update items
17+
set archived = 1
18+
where iditem = ":itemId"`,
19+
values
1520
);
1621

1722
await rdsDataClient.send(command);

javascriptv3/example_code/cross-services/aurora-serverless-app/tests/command-helper.unit.test.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,14 @@ describe("command-helper", () => {
1212
expect(command.input.sql).toBe(sql);
1313
});
1414
});
15+
it("should create an ExecuteStatementCommand with the provided SQL statement and parameters", () => {
16+
const sql = "select * from some_table where id = :id";
17+
const parameters = {
18+
id: { StringValue: "123" },
19+
};
20+
const command = buildStatementCommand(sql, parameters);
21+
expect(command.constructor.name).toBe("ExecuteStatementCommand");
22+
expect(command.input.sql).toBe(sql);
23+
expect(command.input.parameters).toEqual([parameters]);
24+
});
1525
});

javav2/example_code/s3/src/main/java/com/example/s3/GeneratePresignedGetUrlAndRetrieve.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public static void main(String[] args) {
6060
String presignedUrlString = presign.createPresignedGetUrl(bucketName, keyName);
6161
presign.useHttpUrlConnectionToGet(presignedUrlString);
6262
presign.useHttpClientToGet(presignedUrlString);
63-
presign.useSdkHttpClientToPut(presignedUrlString);
63+
presign.useSdkHttpClientToGet(presignedUrlString);
6464
} finally {
6565
PresignUrlUtils.deleteObject(bucketName, keyName, s3Client);
6666
PresignUrlUtils.deleteBucket(bucketName, s3Client);
@@ -142,7 +142,7 @@ public byte[] useHttpClientToGet(String presignedUrlString) {
142142

143143
// snippet-start:[presigned.java2.generatepresignedgeturlandretrieve.sdkhttpclient]
144144
/* Use the AWS SDK for Java SdkHttpClient class to do the download. */
145-
public byte[] useSdkHttpClientToPut(String presignedUrlString) {
145+
public byte[] useSdkHttpClientToGet(String presignedUrlString) {
146146

147147
ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); // Capture the response body to a byte array.
148148
try {

javav2/example_code/s3/src/test/java/com/example/s3/presignurl/GeneratePresignedGetUrlTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void testUsingJdkHttpClient() {
7070
GeneratePresignedGetUrlAndRetrieve presignInstanceUnderTest = new GeneratePresignedGetUrlAndRetrieve();
7171
final String presignedUrlString = presignInstanceUnderTest.createPresignedGetUrl(BUCKET_NAME, KEY_NAME);
7272

73-
final byte[] bytes = presignInstanceUnderTest.useSdkHttpClientToPut(presignedUrlString);
73+
final byte[] bytes = presignInstanceUnderTest.useSdkHttpClientToGet(presignedUrlString);
7474
Assertions.assertTrue(bytes.length > 0);
7575
}
7676
}

0 commit comments

Comments
 (0)