feat: populate track relationship types for Bandcamp

- stream for free, download for free and purchase for download are populated correctly;
- pay what you want is not populated, because that requires some redesign (to query the individual tracks from bandcamp and check their pricing options); more info here #95.

Author: arsinclair

harmonizer/types.ts

@@ -30,6 +30,8 @@ export interface EntityId {
 export interface ExternalEntityId extends EntityId {
 	/** Internal name of the provider. */
 	provider: string;
+	/** Optional link types for this external ID. */
+	linkTypes?: LinkType[];
 }
 
 /** Entity which may have external IDs which can be resolved to its MBID. */

providers/Bandcamp/__snapshots__/mod.test.ts.snap

@@ -74,6 +74,10 @@ suika.love",
             externalIds: [
               {
                 id: "thedarkthursday/suomi-lovely",
+                linkTypes: [
+                  "free streaming",
+                  "paid download",
+                ],
                 provider: "bandcamp",
                 type: "track",
               },
@@ -89,6 +93,10 @@ suika.love",
             externalIds: [
               {
                 id: "thedarkthursday/bittersweet-desires-to-overdose-on-my-prescriptions",
+                linkTypes: [
+                  "free streaming",
+                  "paid download",
+                ],
                 provider: "bandcamp",
                 type: "track",
               },
@@ -104,6 +112,10 @@ suika.love",
             externalIds: [
               {
                 id: "thedarkthursday/set-fire-to-the-space-snow",
+                linkTypes: [
+                  "free streaming",
+                  "paid download",
+                ],
                 provider: "bandcamp",
                 type: "track",
               },

providers/Bandcamp/json_types.ts

@@ -189,7 +189,8 @@ export interface TrackInfo {
 	/** Indicates whether the track can be streamed (can also be `1` for unreleased tracks). */
 	streaming: 1; // = boolean `1 | null`?
 	is_downloadable: boolean | null;
-	has_free_download: null;
+	/** Indicates whether the track is available for free download only (not for purchase). */
+	has_free_download: boolean | null;
 	free_album_download: boolean;
 	/** Duration in seconds (floating point, `0.0` for unreleased tracks). */
 	duration: number;

providers/Bandcamp/mod.ts

@@ -109,11 +109,47 @@ export default class BandcampProvider extends MetadataProvider {
 		}
 	}
 
-	override getLinkTypesForEntity(): LinkType[] {
+	override getLinkTypesForEntity(entity: EntityId): LinkType[] {
+		if (entity.type === 'track') {
+			// For tracks, we need to determine the link types based on the track data
+			// This will be handled by the release lookup when creating the track
+			return [];
+		}
 		// MB has special handling for Bandcamp artist URLs
 		return ['discography page'];
 	}
 
+	/** Determines the link types for a track based on its data. */
+	getTrackLinkTypes(track: TrackInfo | PlayerTrack): LinkType[] {
+		const linkTypes: LinkType[] = [];
+
+		if ('track_streaming' in track) {
+			const playerTrack = track as PlayerTrack;
+			if (playerTrack.track_streaming) {
+				linkTypes.push('free streaming');
+			}
+
+			return linkTypes;
+		}
+
+		const trackInfo = track as TrackInfo;
+
+		if (trackInfo.streaming === 1) {
+			linkTypes.push('free streaming');
+		}
+
+		if (trackInfo.is_downloadable === true) {
+			if (trackInfo.has_free_download) {
+				linkTypes.push('free download');
+			} else {
+				linkTypes.push('paid download');
+				// TODO: And potentially a free download
+			}
+		}
+
+		return linkTypes;
+	}
+
 	extractEmbeddedJson<Data>(webUrl: URL, maxTimestamp?: number): Promise<CacheEntry<Data>> {
 		return this.fetchJSON<Data>(webUrl, {
 			policy: { maxTimestamp },
@@ -349,13 +385,21 @@ export class BandcampReleaseLookup extends ReleaseLookup<BandcampProvider, Relea
 			trackNumber = rawTrack.tracknum + 1;
 		}
 
+		const externalIds = title_link ? this.provider.makeExternalIdsFromUrl(title_link, this.rawReleaseUrl) : [];
+		if (externalIds.length > 0) {
+			const linkTypes = this.provider.getTrackLinkTypes(rawTrack);
+			if (linkTypes.length > 0) {
+				externalIds[0].linkTypes = linkTypes;
+			}
+		}
+
 		return {
 			number: trackNumber,
 			title,
 			artists: artist ? [this.makeArtistCreditName(artist)] : undefined,
 			length: rawTrack.duration * 1000,
 			recording: {
-				externalIds: title_link ? this.provider.makeExternalIdsFromUrl(title_link, this.rawReleaseUrl) : [],
+				externalIds,
 			},
 		};
 	}

server/components/LinkWithMusicBrainz.tsx

@@ -38,7 +38,7 @@ export function LinkWithMusicBrainz({ entity, entityType, sourceEntityUrl, entit
 		const provider = providers.findByName(externalId.provider)!;
 		return {
 			url: provider.constructUrl(externalId).href,
-			types: provider.getLinkTypesForEntity(externalId),
+			types: externalId.linkTypes ?? provider.getLinkTypesForEntity(externalId),
 		};
 	}).filter((link) => !existingLinks.has(link.url));