fix(Bandcamp): Properly serialize additional strings for embedded JSON

kellnerd · kellnerd · commit 563b7c85173f · 2025-12-01T18:53:49.000+01:00
https://ibelieveinangels.bandcamp.com/track/salvation uses backslashes in its og:description that have to be escaped: > Bad escaped character in JSON at position 2812 (line 1 column 2813)
diff --git a/providers/Bandcamp/mod.ts b/providers/Bandcamp/mod.ts
@@ -171,12 +171,12 @@ export default class BandcampProvider extends MetadataProvider {
 
 					const description = extractMetadataTag(html, 'og:description');
 					if (description) {
-						jsonEntries.push(['og:description', `"${description}"`]);
+						jsonEntries.push(['og:description', JSON.stringify(description)]);
 					}
 
 					const licenseUrl = extractTextFromHtml(html, /class="cc-icons"\s+href="([^"]+)"/i);
 					if (licenseUrl) {
-						jsonEntries.push(['licenseUrl', `"${licenseUrl}"`]);
+						jsonEntries.push(['licenseUrl', JSON.stringify(licenseUrl)]);
 					}
 
 					const json = `{${jsonEntries.map(([key, serializedValue]) => `"${key}":${serializedValue}`).join(',')}}`;

Original file line number	Diff line number	Diff line change
`@@ -171,12 +171,12 @@ export default class BandcampProvider extends MetadataProvider {`
`171`	`171`
`172`	`172`	`const description = extractMetadataTag(html, 'og:description');`
`173`	`173`	`if (description) {`
`174`		- jsonEntries.push(['og:description', `"${description}"`]);
	`174`	`+ jsonEntries.push(['og:description', JSON.stringify(description)]);`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`const licenseUrl = extractTextFromHtml(html, /class="cc-icons"\s+href="([^"]+)"/i);`
`178`	`178`	`if (licenseUrl) {`
`179`		- jsonEntries.push(['licenseUrl', `"${licenseUrl}"`]);
	`179`	`+ jsonEntries.push(['licenseUrl', JSON.stringify(licenseUrl)]);`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	const json = `{${jsonEntries.map(([key, serializedValue]) => `"${key}":${serializedValue}`).join(',')}}`;