feat(seed): Support updating an existing release with external links

No deduplication of links is performed because Harmony does not cache
the necessary data from the MB API. Changing the API include parameters
would unfortunately be a breaking change for permalinks.

Having link deduplication in MBS would be very useful:
https://tickets.metabrainz.org/browse/MBS-13993

Author: kellnerd

musicbrainz/seeding.ts

@@ -27,6 +27,8 @@ export interface ReleaseSeedOptions {
 	redirectUrl?: URL;
 	/** Base URL of the Harmony instance which was used to seed the release, for permalinks. */
 	seederUrl?: URL;
+	/** Indicates whether the seed will be used to update an existing release. */
+	isUpdate?: boolean;
 	/** Options for the annotation builder. */
 	annotation?: AnnotationIncludes;
 }
@@ -53,6 +55,30 @@ export function createReleaseSeed(release: HarmonyRelease, options: ReleaseSeedO
 		redirectUrl.search = lookupState.toString();
 	}
 
+	const externalLinks: ReleaseUrlSeed[] = release.externalLinks.flatMap((link) =>
+		link.types?.length
+			? link.types.map((type) => ({
+				url: link.url,
+				link_type: convertLinkType('release', type, new URL(link.url)),
+			}))
+			: ({
+				url: link.url,
+			})
+	);
+
+	if (options.isUpdate) {
+		// Only seed external links for now, updating other properties is more controversial.
+		// For some properties (such as the tracklist) seeding updates is even affected by bugs:
+		// https://tickets.metabrainz.org/browse/MBS-13688
+		const seed: Omit<ReleaseSeed, 'name'> = {
+			urls: externalLinks,
+			edit_note: buildEditNote(release.info, options),
+			redirect_uri: redirectUrl?.href,
+		};
+
+		return flatten(seed);
+	}
+
 	const seed: ReleaseSeed = {
 		name: release.title,
 		artist_credit: convertArtistCredit(release.artists),
@@ -83,16 +109,7 @@ export function createReleaseSeed(release: HarmonyRelease, options: ReleaseSeedO
 		})),
 		language: release.language?.code,
 		script: release.script?.code,
-		urls: release.externalLinks.flatMap<ReleaseUrlSeed>((link) =>
-			link.types?.length
-				? link.types.map((type) => ({
-					url: link.url,
-					link_type: convertLinkType('release', type, new URL(link.url)),
-				}))
-				: ({
-					url: link.url,
-				})
-		),
+		urls: externalLinks,
 		annotation: buildAnnotation(release, options.annotation),
 		edit_note: buildEditNote(release.info, options),
 		redirect_uri: redirectUrl?.href,
@@ -187,7 +204,7 @@ function buildEditNote(info: ReleaseInfo, options: ReleaseSeedOptions): string {
 
 	const { projectUrl, seederUrl } = options;
 	const sourceUrl = seederUrl ? createReleasePermalink(info, seederUrl) : projectUrl;
-	lines.unshift(`Imported with Harmony (${sourceUrl}), using data from:`);
+	lines.unshift(`${options.isUpdate ? 'Updated' : 'Imported'} with Harmony (${sourceUrl}), using data from:`);
 
 	return lines.join('\n');
 }

server/islands/ReleaseSeeder.tsx

@@ -14,12 +14,14 @@ export function ReleaseSeeder({ release, sourceUrl, targetUrl, projectUrl }: {
 	targetUrl: string;
 }) {
 	const seederSourceUrl = sourceUrl ? new URL(sourceUrl) : undefined;
+	const isUpdate = targetUrl.endsWith('/edit');
 	const seed = createReleaseSeed(release, {
 		projectUrl: new URL(projectUrl),
 		redirectUrl: (seederSourceUrl && checkSetting('seeder.redirect', true))
 			? new URL('release/actions', seederSourceUrl)
 			: undefined,
 		seederUrl: seederSourceUrl,
+		isUpdate,
 		annotation: {
 			availability: checkSetting('annotation.availability', false),
 			copyright: checkSetting('annotation.copyright', true),
@@ -28,12 +30,20 @@ export function ReleaseSeeder({ release, sourceUrl, targetUrl, projectUrl }: {
 	});
 
 	return (
-		<form action={targetUrl} method='post' target={getSetting('seeder.target', '_blank')} name='release-seeder'>
+		<form
+			action={targetUrl}
+			method='post'
+			target={getSetting('seeder.target', '_blank')}
+			name={isUpdate ? 'release-update-seeder' : 'release-seeder'}
+		>
 			{Object.entries(seed).flatMap(([key, valueOrValues]) => {
 				return preferArray(valueOrValues).map((value) => <input type='hidden' name={key} value={value} />);
 			})}
-			<InputWithOverlay type='submit' value='Import into MusicBrainz'>
-				<SpriteIcon name='database-import' />
+			<InputWithOverlay
+				type='submit'
+				value={isUpdate ? 'Update external links in MusicBrainz' : 'Import into MusicBrainz'}
+			>
+				<SpriteIcon name={isUpdate ? 'database-edit' : 'database-import'} />
 			</InputWithOverlay>
 		</form>
 	);

server/routes/icon-sprite.svg.tsx

@@ -10,6 +10,7 @@ import IconBrandTidal from 'tabler-icons/brand-tidal.tsx';
 import IconAlertTriangle from 'tabler-icons/alert-triangle.tsx';
 import IconBarcode from 'tabler-icons/barcode.tsx';
 import IconBug from 'tabler-icons/bug.tsx';
+import IconDatabaseEdit from 'tabler-icons/database-edit.tsx';
 import IconDatabaseImport from 'tabler-icons/database-import.tsx';
 import IconDisc from 'tabler-icons/disc.tsx';
 import IconHelp from 'tabler-icons/help.tsx';
@@ -32,6 +33,7 @@ const icons: Icon[] = [
 	IconAlertTriangle,
 	IconBarcode,
 	IconBug,
+	IconDatabaseEdit,
 	IconDatabaseImport,
 	IconDisc,
 	IconHelp,

server/routes/release.tsx

@@ -28,6 +28,7 @@ export default defineRoute(async (req, ctx) => {
 	let releaseMap: ProviderReleaseMap | undefined;
 	let enabledProviders: Set<string> | undefined = undefined;
 	let gtinInput: GTIN = '', urlInput = '', regionsInput: string[] = [];
+	let existingMBID: string | undefined;
 
 	try {
 		const {
@@ -63,6 +64,7 @@ export default defineRoute(async (req, ctx) => {
 
 			const mbInfo = release.info.providers.find((provider) => provider.name === 'MusicBrainz');
 			if (mbInfo) {
+				existingMBID = mbInfo.id;
 				release.info.messages.push({
 					text:
 						`Release with GTIN ${release.gtin} already exists on MusicBrainz ([show actions](release/actions?release_mbid=${mbInfo.id}))`,
@@ -120,12 +122,22 @@ export default defineRoute(async (req, ctx) => {
 				))}
 				{release && <Release release={release} releaseMap={releaseMap} />}
 				{release && (
-					<ReleaseSeeder
-						release={release}
-						projectUrl={codeUrl.href}
-						sourceUrl={seederSourceUrl.href}
-						targetUrl={seederTargetUrl.href}
-					/>
+					<div class='row'>
+						<ReleaseSeeder
+							release={release}
+							projectUrl={codeUrl.href}
+							sourceUrl={seederSourceUrl.href}
+							targetUrl={seederTargetUrl.href}
+						/>
+						{existingMBID && (
+							<ReleaseSeeder
+								release={release}
+								projectUrl={codeUrl.href}
+								sourceUrl={seederSourceUrl.href}
+								targetUrl={join(musicbrainzTargetServer, 'release', existingMBID, 'edit').href}
+							/>
+						)}
+					</div>
 				)}
 			</main>
 		</>