fix(provider): Throw error when we ignore too large Retry-After delay

Otherwise the Spotify provider immediately retries HTTP 429 requests.

Author: kellnerd

providers/base.ts

@@ -257,11 +257,22 @@ export abstract class MetadataProvider {
 	/** Handles rate limit HTTP headers and sets the request delay. */
 	protected handleRateLimit(response: Response) {
 		const retryAfter = response.headers.get('Retry-After');
+		const relevantHeaders = Object.fromEntries(
+			[...response.headers].filter(([key, _value]) => key.includes('rate')),
+		);
+		this.log.warn(`${this.name} rate limit headers: ${JSON.stringify(relevantHeaders)}`);
 		if (retryAfter) {
 			this.log.info(`${this.name} rate limit (HTTP ${response.status}): Retry-After ${retryAfter}`);
 			const retryAfterMs = parseInt(retryAfter) * 1000;
-			if (retryAfterMs > 0 && retryAfterMs < this.requestMaxDelay) {
-				this.requestDelay = delay(retryAfterMs);
+			if (retryAfterMs > 0) {
+				if (retryAfterMs < this.requestMaxDelay) {
+					this.requestDelay = delay(retryAfterMs);
+				} else {
+					throw new ProviderError(
+						this.name,
+						`Suggested rate limit delay is unacceptably high, cancelling request (Retry-After ${retryAfter})`,
+					);
+				}
 			}
 		}
 	}