Skip to content

Commit 8d1dc30

Browse files
committed
Refactor version number generation to use environment variables for major and minor version
1 parent c9f5f57 commit 8d1dc30

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ on:
77
tags:
88
- 'v*'
99

10+
env:
11+
MAJOR_VERSION: 1
12+
MINOR_VERSION: 0
13+
1014
jobs:
1115
build-and-release:
1216
runs-on: windows-latest
@@ -41,7 +45,7 @@ jobs:
4145
- name: Generate version number
4246
id: version
4347
run: |
44-
$version = "1.0.${{ github.run_number }}"
48+
$version = "${{ env.MAJOR_VERSION }}.${{ env.MINOR_VERSION }}.${{ github.run_number }}"
4549
echo "VERSION=$version" >> $env:GITHUB_OUTPUT
4650
echo "Version: $version"
4751
@@ -50,8 +54,8 @@ jobs:
5054
@"
5155
VSVersionInfo(
5256
ffi=FixedFileInfo(
53-
filevers=(1, 0, ${{ github.run_number }}, 0),
54-
prodvers=(1, 0, ${{ github.run_number }}, 0),
57+
filevers=(${{ env.MAJOR_VERSION }}, ${{ env.MINOR_VERSION }}, ${{ github.run_number }}, 0),
58+
prodvers=(${{ env.MAJOR_VERSION }}, ${{ env.MINOR_VERSION }}, ${{ github.run_number }}, 0),
5559
mask=0x3f,
5660
flags=0x0,
5761
OS=0x40004,
@@ -65,12 +69,12 @@ jobs:
6569
u'040904B0',
6670
[StringStruct(u'CompanyName', u'kelltom'),
6771
StringStruct(u'FileDescription', u'ChiselPDF - PDF Page Selector'),
68-
StringStruct(u'FileVersion', u'1.0.${{ github.run_number }}.0'),
72+
StringStruct(u'FileVersion', u'${{ env.MAJOR_VERSION }}.${{ env.MINOR_VERSION }}.${{ github.run_number }}.0'),
6973
StringStruct(u'InternalName', u'ChiselPDF'),
7074
StringStruct(u'LegalCopyright', u'Copyright (c) 2025 kelltom'),
7175
StringStruct(u'OriginalFilename', u'ChiselPDF.exe'),
7276
StringStruct(u'ProductName', u'ChiselPDF'),
73-
StringStruct(u'ProductVersion', u'1.0.${{ github.run_number }}.0')])
77+
StringStruct(u'ProductVersion', u'${{ env.MAJOR_VERSION }}.${{ env.MINOR_VERSION }}.${{ github.run_number }}.0')])
7478
]),
7579
VarFileInfo([VarStruct(u'Translation', [1033, 1200])])
7680
]

0 commit comments

Comments
 (0)