fix clippy

Author: hotate29

atcoder-problems-backend/atcoder-client/src/atcoder/client.rs

@@ -40,7 +40,7 @@ impl AtCoderClient {
 
     async fn fetch_atcoder_hidden_contests(&self) -> Result<Vec<AtCoderContest>> {
         let uri = "https://kenkoooo.com/atcoder/static_data/backend/hidden_contests.json";
-        util::get_json(&uri).await
+        util::get_json(uri).await
     }
 
     /// Fetch a list of submissions.
@@ -105,7 +105,7 @@ mod tests {
         let client = AtCoderClient::default();
         let contests =
             block_on(client.fetch_atcoder_contests(ContestTypeSpecifier::Hidden)).unwrap();
-        assert!(contests.len() >= 1);
+        assert!(!contests.is_empty());
     }
 
     #[test]

atcoder-problems-backend/atcoder-client/src/atcoder/contest.rs

@@ -22,7 +22,7 @@ pub(super) fn scrape_normal(html: &str) -> Result<Vec<AtCoderContest>> {
                 .text()
                 .next()
                 .ok_or_else(|| anyhow!("Failed to parse html."))?;
-            let start = DateTime::parse_from_str(&start, "%Y-%m-%d %H:%M:%S%z")?;
+            let start = DateTime::parse_from_str(start, "%Y-%m-%d %H:%M:%S%z")?;
             let start = start.timestamp() as u64;
 
             let contest = tds.next().ok_or_else(|| anyhow!("Failed to parse html."))?;

atcoder-problems-backend/atcoder-client/src/atcoder/submission.rs

@@ -9,7 +9,7 @@ use scraper::{Html, Selector};
 pub(super) fn scrape_submission_page_count(html: &str) -> Result<u32> {
     let selector = Selector::parse("a").unwrap();
     let re = Regex::new(r"page=\d+$").unwrap();
-    Html::parse_document(&html)
+    Html::parse_document(html)
         .select(&selector)
         .flat_map(|el| el.value().attr("href"))
         .filter(|href| re.is_match(href))
@@ -26,7 +26,7 @@ pub(super) fn scrape(html_text: &str, contest_id: &str) -> Result<Vec<AtCoderSub
     let a_selector = Selector::parse("a").unwrap();
     let re = Regex::new(r"submissions/\d+$").unwrap();
 
-    Html::parse_document(&html_text)
+    Html::parse_document(html_text)
         .select(&tbody_selector)
         .next()
         .ok_or_else(|| anyhow!("Failed to parse html."))?
@@ -40,7 +40,7 @@ pub(super) fn scrape(html_text: &str, contest_id: &str) -> Result<Vec<AtCoderSub
                 .text()
                 .next()
                 .ok_or_else(|| anyhow!("Failed to parse html."))?;
-            let time = DateTime::parse_from_str(&time, "%Y-%m-%d %H:%M:%S%z")?;
+            let time = DateTime::parse_from_str(time, "%Y-%m-%d %H:%M:%S%z")?;
             let epoch_second = time.timestamp() as u64;
 
             let problem_id = tds

atcoder-problems-backend/sql-client/src/language_count.rs

@@ -48,7 +48,7 @@ impl LanguageCountClient for PgPool {
             .fold(
                 BTreeMap::new(),
                 |mut map, (user_id, problem_id, language)| {
-                    let simplified_language = simplify_language(&language);
+                    let simplified_language = simplify_language(language);
                     map.entry((user_id, simplified_language))
                         .or_insert_with(BTreeSet::new)
                         .insert(problem_id);

atcoder-problems-backend/sql-client/tests/test_contest_problem.rs

@@ -15,14 +15,14 @@ async fn test_contest_problem() {
     let pool = utils::initialize_and_connect_to_test_sql().await;
     assert!(pool.load_contest_problem().await.unwrap().is_empty());
 
-    pool.insert_contest_problem(&vec![create_problem(1), create_problem(2)])
+    pool.insert_contest_problem(&[create_problem(1), create_problem(2)])
         .await
         .unwrap();
     assert_eq!(
         pool.load_contest_problem().await.unwrap(),
         vec![create_problem(1), create_problem(2)]
     );
-    pool.insert_contest_problem(&vec![create_problem(1)])
+    pool.insert_contest_problem(&[create_problem(1)])
         .await
         .unwrap();
     assert_eq!(

atcoder-problems-backend/sql-client/tests/test_language_count.rs

@@ -133,7 +133,7 @@ async fn test_language_count() {
     );
 
     let language_count_1st_to_2nd = pool
-        .load_language_count_in_range(&"language1", 0..2)
+        .load_language_count_in_range("language1", 0..2)
         .await
         .unwrap();
     assert_eq!(
@@ -151,7 +151,7 @@ async fn test_language_count() {
     );
 
     let language_count_2nd_to_2nd = pool
-        .load_language_count_in_range(&"language1", 1..2)
+        .load_language_count_in_range("language1", 1..2)
         .await
         .unwrap();
     assert_eq!(
@@ -163,14 +163,14 @@ async fn test_language_count() {
     );
 
     assert_eq!(
-        pool.load_language_count_in_range(&"language1", 0..10)
+        pool.load_language_count_in_range("language1", 0..10)
             .await
             .unwrap()
             .len(),
         2
     );
 
-    let language_count = pool.load_users_language_count(&"user1").await.unwrap();
+    let language_count = pool.load_users_language_count("user1").await.unwrap();
     assert_eq!(
         language_count,
         vec![
@@ -186,7 +186,7 @@ async fn test_language_count() {
             },
         ]
     );
-    let language_count_rank = pool.load_users_language_count_rank(&"user1").await.unwrap();
+    let language_count_rank = pool.load_users_language_count_rank("user1").await.unwrap();
     assert_eq!(
         language_count_rank,
         vec![
@@ -203,7 +203,7 @@ async fn test_language_count() {
         ]
     );
 
-    let language_count = pool.load_users_language_count(&"user2").await.unwrap();
+    let language_count = pool.load_users_language_count("user2").await.unwrap();
     assert_eq!(
         language_count,
         vec![UserLanguageCount {
@@ -212,7 +212,7 @@ async fn test_language_count() {
             problem_count: 1,
         },]
     );
-    let language_count_rank = pool.load_users_language_count_rank(&"user2").await.unwrap();
+    let language_count_rank = pool.load_users_language_count_rank("user2").await.unwrap();
     assert_eq!(
         language_count_rank,
         vec![UserLanguageCountRank {
@@ -222,7 +222,7 @@ async fn test_language_count() {
         },]
     );
 
-    let language_count = pool.load_users_language_count(&"user3").await.unwrap();
+    let language_count = pool.load_users_language_count("user3").await.unwrap();
     assert_eq!(
         language_count,
         vec![
@@ -238,7 +238,7 @@ async fn test_language_count() {
             },
         ]
     );
-    let language_count_rank = pool.load_users_language_count_rank(&"user3").await.unwrap();
+    let language_count_rank = pool.load_users_language_count_rank("user3").await.unwrap();
     assert_eq!(
         language_count_rank,
         vec![

atcoder-problems-backend/sql-client/tests/test_simple_client.rs

@@ -7,7 +7,7 @@ mod utils;
 async fn test_insert_contests() {
     let pool = utils::initialize_and_connect_to_test_sql().await;
     assert!(pool.load_contests().await.unwrap().is_empty());
-    pool.insert_contests(&vec![Contest {
+    pool.insert_contests(&[Contest {
         id: "contest1".to_string(),
         start_epoch_second: 0,
         duration_second: 0,
@@ -20,7 +20,7 @@ async fn test_insert_contests() {
     let contests = pool.load_contests().await.unwrap();
     assert_eq!(contests[0].id.as_str(), "contest1");
 
-    pool.insert_contests(&vec![Contest {
+    pool.insert_contests(&[Contest {
         id: "contest1".to_string(),
         start_epoch_second: 0,
         duration_second: 0,
@@ -35,7 +35,7 @@ async fn test_insert_contests() {
 async fn test_insert_problems() {
     let pool = utils::initialize_and_connect_to_test_sql().await;
     assert!(pool.load_problems().await.unwrap().is_empty());
-    pool.insert_problems(&vec![Problem {
+    pool.insert_problems(&[Problem {
         id: "problem1".to_string(),
         contest_id: "".to_string(),
         title: "".to_string(),
@@ -46,7 +46,7 @@ async fn test_insert_problems() {
     let problems = pool.load_problems().await.unwrap();
     assert_eq!(problems[0].id.as_str(), "problem1");
 
-    pool.insert_problems(&vec![Problem {
+    pool.insert_problems(&[Problem {
         id: "problem1".to_string(),
         contest_id: "".to_string(),
         title: "".to_string(),

atcoder-problems-backend/src/bin/delta_update.rs

@@ -24,13 +24,10 @@ async fn main() -> Result<(), Box<dyn Error>> {
     let recent_submissions = conn.get_submissions(request).await?;
 
     info!("Filter submission by user_id ...");
-    let recent_submissions = recent_submissions
-        .into_iter()
-        .filter(|submission| !EXCLUDED_USERS.contains(&submission.user_id.as_str()))
-        .collect::<Vec<_>>();
 
     let user_ids = recent_submissions
         .into_iter()
+        .filter(|submission| !EXCLUDED_USERS.contains(&submission.user_id.as_str()))
         .map(|s| s.user_id)
         .collect::<BTreeSet<_>>();
     let user_ids = user_ids.iter().map(|s| s.as_str()).collect::<Vec<_>>();

atcoder-problems-backend/src/server/problem_list.rs

@@ -21,7 +21,7 @@ where
 {
     let list_id = request.param("list_id")?;
     let conn = request.state().pg_pool.clone();
-    let list = conn.get_single_list(&list_id).await?;
+    let list = conn.get_single_list(list_id).await?;
     let response = Response::json(&list)?;
     Ok(response)
 }

atcoder-problems-backend/src/server/utils.rs

@@ -18,7 +18,7 @@ impl<A: Authentication + Clone + Send + Sync + 'static> RequestUnpack for Reques
         let client = self.state().authentication.clone();
         let token = self.cookie("token").with_context(|| "Cookie not found")?;
         let response = client
-            .get_user_id(&token.value())
+            .get_user_id(token.value())
             .await
             .map_err(|_| anyhow::Error::msg("GitHub connection error"))?;
         Ok(response.id.to_string())