不要なclone, アロケーションを削除

Author: hotate29

atcoder-problems-backend/src/server/endpoint/internal_api/mod.rs

@@ -32,10 +32,7 @@ pub async fn get_authorize(
         .await
         .map_internal_server_err()?;
     let cookie = Cookie::build("token", token).path("/").finish();
-    let redirect_fragment = query
-        .redirect_to
-        .clone()
-        .unwrap_or_else(|| "/login/user".to_string());
+    let redirect_fragment = query.redirect_to.as_deref().unwrap_or("/login/user");
     let redirect_url = format!("{}#{}", REDIRECT_URL, redirect_fragment);
     let response = HttpResponse::Found()
         .insert_header((LOCATION, redirect_url))

atcoder-problems-backend/src/server/middleware/github_auth.rs

@@ -139,8 +139,8 @@ where
         let client = Rc::clone(&self.client);
         async move {
             if let Some(cookie) = req.cookie("token") {
-                let token = cookie.value().to_string();
-                if let Ok(token) = client.verify_user(&token).await {
+                let token = cookie.value();
+                if let Ok(token) = client.verify_user(token).await {
                     req.extensions_mut().insert(token);
                 }
             }

atcoder-problems-backend/src/server/user_info.rs

@@ -23,20 +23,22 @@ pub(crate) async fn get_user_info(
     pool: web::Data<PgPool>,
     query: web::Query<Query>,
 ) -> Result<HttpResponse> {
-    let user_id = &query.user;
-    let accepted_count = pool.get_users_accepted_count(user_id).await.unwrap_or(0);
+    let query = query.into_inner();
+    let user_id = query.user;
+
+    let accepted_count = pool.get_users_accepted_count(&user_id).await.unwrap_or(0);
     let accepted_count_rank = pool
         .get_accepted_count_rank(accepted_count)
         .await
         .map_err(error::ErrorInternalServerError)?;
-    let rated_point_sum = pool.get_users_rated_point_sum(user_id).await.unwrap_or(0);
+    let rated_point_sum = pool.get_users_rated_point_sum(&user_id).await.unwrap_or(0);
     let rated_point_sum_rank = pool
         .get_rated_point_sum_rank(rated_point_sum)
         .await
         .map_err(error::ErrorInternalServerError)?;
 
     let user_info = UserInfo {
-        user_id: user_id.clone(),
+        user_id,
         accepted_count,
         accepted_count_rank,
         rated_point_sum,

atcoder-problems-backend/tests/utils.rs

@@ -22,12 +22,10 @@ pub async fn initialize_and_connect_to_test_sql() -> PgPool {
 
 pub fn start_mock_github_server(access_token: &str) -> MockServer {
     let server = MockServer::start();
-    let token = access_token.to_string();
     server.mock(|when, then| {
         when.method("POST").path("/login/oauth/access_token");
-        then.status(200).json_body(json!({
-            "access_token": token.clone()
-        }));
+        then.status(200)
+            .json_body(json!({ "access_token": access_token }));
     });
     server
 }