微修正

- 不要な`.into_iter()`を削除した
- `.to_string()`と`.clone()`を使い分けるようにした
- 不要な`..`を削除した

Author: hotate29

atcoder-problems-backend/sql-client/src/internal/problem_list_manager.rs

@@ -70,7 +70,7 @@ impl ProblemListManager for PgPool {
         .fetch_all(self)
         .await?;
         let mut map = BTreeMap::new();
-        for (list_id, list_name, user_id, problem_id, memo) in items.into_iter() {
+        for (list_id, list_name, user_id, problem_id, memo) in items {
             let list = map
                 .entry(list_id)
                 .or_insert((list_name, user_id, Vec::new()));
@@ -125,7 +125,7 @@ impl ProblemListManager for PgPool {
         .fetch_all(self)
         .await?;
         let mut map = BTreeMap::new();
-        for (list_id, list_name, user_id, problem_id, memo) in items.into_iter() {
+        for (list_id, list_name, user_id, problem_id, memo) in items {
             let list = map
                 .entry(list_id)
                 .or_insert((list_name, user_id, Vec::new()));

atcoder-problems-backend/src/bin/crawl_all_submissions.rs

@@ -20,7 +20,7 @@ async fn main() {
 
         match load_contest(&url).await {
             Ok(contests) => {
-                for contest in contests.into_iter() {
+                for contest in contests {
                     finish_one_contest(&url, &contest.id).await;
                 }
             }

atcoder-problems-backend/src/crawler/fix_crawler.rs

@@ -46,7 +46,7 @@ where
             },
         );
 
-        for (contest_id, minimum_id) in contests.into_iter() {
+        for (contest_id, minimum_id) in contests {
             for page in 1.. {
                 info!("Fetching from {}-{}", contest_id, page);
                 let (submissions, max_page) =

atcoder-problems-backend/src/crawler/mod.rs

@@ -128,9 +128,9 @@ fn convert_problem(p: AtCoderProblem) -> Problem {
     Problem {
         id: p.id,
         contest_id: p.contest_id,
-        problem_index: p.position.to_string(),
+        problem_index: p.position.clone(),
         title: p.position + ". " + p.title.as_str(),
-        name: p.title.to_string(),
+        name: p.title,
     }
 }
 

atcoder-problems-backend/src/crawler/problem_crawler.rs

@@ -82,7 +82,7 @@ where
         let no_problem_contests =
             extract_no_problem_contests(&contests, &problems, &contest_problem);
 
-        for contest in no_problem_contests.into_iter() {
+        for contest in no_problem_contests {
             log::info!("Crawling problems of {}...", contest.id);
             match self.fetcher.fetch_problems(&contest.id).await {
                 Ok((problems, contest_problem)) => {

atcoder-problems-backend/src/crawler/recent_crawler.rs

@@ -23,7 +23,7 @@ where
     pub async fn crawl(&self) -> Result<()> {
         info!("Started");
         let contests = self.db.load_contests().await?;
-        for contest in contests.into_iter() {
+        for contest in contests {
             for page in 1.. {
                 info!("Crawling {}-{} ...", contest.id, page);
                 let (submissions, max_page) =

atcoder-problems-backend/src/crawler/virtual_contest_crawler.rs

@@ -62,7 +62,7 @@ where
             .collect::<BTreeSet<_>>();
         log::info!("Loaded {} contests", contest_set.len());
 
-        for contest in contest_set.into_iter() {
+        for contest in contest_set {
             log::info!("Starting {} ...", contest);
             let mut streak = 0;
             for page in 1.. {

atcoder-problems-backend/src/server/user_submissions.rs

@@ -66,7 +66,6 @@ pub(crate) async fn get_user_submission_count(
         user: ref user_id,
         from_second: Some(from_second),
         to_second: Some(to_second),
-        ..
     } = *query
     {
         let range = from_second..to_second;