bug: fixed funcs

Author: nebocco

atcoder-problems-backend/src/server/problem_list.rs

@@ -19,21 +19,14 @@ pub(crate) async fn get_own_lists<A: Authentication + Clone + Send + Sync + 'sta
     Ok(response)
 }
 
-#[derive(Deserialize)]
-pub(crate) struct GetListQuery {
-    list_id: String,
-}
-
-pub(crate) async fn get_single_list<A: Authentication + Clone + Send + Sync + 'static>(
+pub(crate) async fn get_single_list<A>(
     request: HttpRequest,
     data: web::Data<AppData<A>>,
-    query: web::Query<GetListQuery>,
+    list_id: web::Path<String>,
 ) -> Result<HttpResponse> {
-    let user_id = data.get_authorized_id(request.cookie("token")).await?;
     let conn = data.pg_pool.clone();
-    let list_id = &query.list_id;
     let list = conn
-        .get_single_list(list_id)
+        .get_single_list(&list_id)
         .await
         .map_err(error::ErrorInternalServerError)?;
     let response = HttpResponse::json(&list)?;

atcoder-problems-backend/src/server/ranking/mod.rs

@@ -42,7 +42,7 @@ pub(crate) trait RankingSelector<A: Sync + Send + Clone + 'static> {
     async fn get_ranking(request: HttpRequest, data: web::Data<AppData<A>>, query: web::Query<RankingRequest>) -> Result<HttpResponse> {
         let query = (query.from)..(query.to);
         if query.len() > MAX_RANKING_RANGE_LENGTH {
-            return Ok(HttpResponse::Ok().finish());
+            return Ok(HttpResponse::BadRequest().finish());
         }
         let ranking = Self::fetch(data, query).await?;
         let response = HttpResponse::json(&ranking)?;
@@ -153,7 +153,7 @@ pub(crate) async fn get_language_ranking<A>(
     let conn = data.pg_pool.clone();
     let range = (query.from)..(query.to);
     if range.len() > MAX_RANKING_RANGE_LENGTH {
-        return Ok(HttpResponse::Ok().finish());
+        return Ok(HttpResponse::BadRequest().finish());
     }
 
     let ranking = conn

atcoder-problems-backend/src/server/rated_point_sum_ranking.rs

@@ -19,7 +19,7 @@ pub(crate) async fn get_rated_point_sum_ranking<A>(
     let conn = data.pg_pool.clone();
     let query = (query.from)..(query.to);
     if query.len() > MAX_RANKING_RANGE_LENGTH {
-        return Ok(HttpResponse::Ok().finish());
+        return Ok(HttpResponse::BadRequest().finish());
     }
 
     let ranking = conn

atcoder-problems-backend/src/server/time_submissions.rs

@@ -3,17 +3,13 @@ use actix_web::{error, web, HttpRequest, HttpResponse, Result};
 use serde::Deserialize;
 use sql_client::submission_client::{SubmissionClient, SubmissionRequest};
 
-#[derive(Deserialize)]
-pub(crate) struct Query {
-    from: i64,
-}
 
 pub(crate) async fn get_time_submissions<A>(
     request: HttpRequest,
     data: web::Data<AppData<A>>,
-    query: web::Query<Query>,
+    from: web::Path<i64>,
 ) -> Result<HttpResponse> {
-    let from_epoch_second = query.from;
+    let from_epoch_second = from.into_inner();
     let conn = data.pg_pool.clone();
     let submissions: Vec<_> = conn
         .get_submissions(SubmissionRequest::FromTime {

atcoder-problems-backend/src/server/virtual_contest.rs

@@ -117,28 +117,22 @@ pub(crate) async fn get_participated<A: Authentication + Clone + Send + Sync + '
     Ok(response)
 }
 
-#[derive(Deserialize)]
-pub(crate) struct SingleContestQuery {
-    contest_id: String
-}
-
-pub(crate) async fn get_single_contest<A: Authentication + Clone + Send + Sync + 'static>(
+pub(crate) async fn get_single_contest<A>(
     request: HttpRequest,
     data: web::Data<AppData<A>>,
-    query: web::Query<SingleContestQuery>,
+    contest_id: web::Path<String>,
 ) -> Result<HttpResponse> {
     #[derive(Serialize)]
     struct VirtualContestDetails {
         info: VirtualContestInfo,
         problems: Vec<VirtualContestItem>,
         participants: Vec<String>,
     }
-    let user_id = data.get_authorized_id(request.cookie("token")).await?;
+
     let conn = data.pg_pool.clone();
-    let contest_id = &query.contest_id;
-    let info = conn.get_single_contest_info(contest_id).await.map_err(error::ErrorInternalServerError)?;
-    let participants = conn.get_single_contest_participants(contest_id).await.map_err(error::ErrorInternalServerError)?;
-    let problems = conn.get_single_contest_problems(contest_id).await.map_err(error::ErrorInternalServerError)?;
+    let info = conn.get_single_contest_info(&contest_id).await.map_err(error::ErrorInternalServerError)?;
+    let participants = conn.get_single_contest_participants(&contest_id).await.map_err(error::ErrorInternalServerError)?;
+    let problems = conn.get_single_contest_problems(&contest_id).await.map_err(error::ErrorInternalServerError)?;
     let contest = VirtualContestDetails {
         info,
         problems,
@@ -155,6 +149,11 @@ pub(crate) async fn get_recent_contests<A>(request: HttpRequest, data: web::Data
     Ok(response)
 }
 
+#[derive(Deserialize)]
+pub(crate) struct SingleContestQuery {
+    contest_id: String
+}
+
 pub(crate) async fn join_contest<A: Authentication + Clone + Send + Sync + 'static>(
     request: HttpRequest,
     data: web::Data<AppData<A>>,