Skip to content

Commit ec7a22d

Browse files
committed
modify: Format change in RPS ranking API
1 parent 5737038 commit ec7a22d

File tree

2 files changed

+9
-23
lines changed

2 files changed

+9
-23
lines changed

atcoder-problems-backend/src/server/ranking/rated_point_sum.rs

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,28 @@
11
use super::{
2-
RankingRequest, RankingRequestFormat, RankingResponseFormat, RankingSelector, UserRankRequest,
2+
RankingRequest, RankingRequestFormat, RankingResponse, RankingSelector, UserRankRequest,
33
UserRankResponse, UserRankSelector,
44
};
55

66
use actix_web::{error, web, Result};
77
use async_trait::async_trait;
8-
use serde::Serialize;
98
use sql_client::{rated_point_sum::RatedPointSumClient, PgPool};
109

11-
#[deprecated(
12-
note = "this special Response type is deprecated and will be replaced with super::RankingResponse"
13-
)]
14-
#[derive(Debug, Serialize)]
15-
pub(crate) struct RPSRankingResponse {
16-
user_id: String,
17-
count: i64,
18-
point_sum: i64,
19-
}
20-
21-
impl RankingResponseFormat for RPSRankingResponse {}
22-
2310
pub(crate) struct RatedPointSumRanking;
2411

2512
#[async_trait(?Send)]
2613
impl RankingSelector for RatedPointSumRanking {
2714
type Request = RankingRequest;
28-
type Response = RPSRankingResponse;
15+
type Response = RankingResponse;
2916
async fn fetch(pool: web::Data<PgPool>, query: Self::Request) -> Result<Vec<Self::Response>> {
3017
let ranking = pool
3118
.load_rated_point_sum_in_range(query.range())
3219
.await
3320
.map_err(error::ErrorInternalServerError)?;
3421
Ok(ranking
3522
.into_iter()
36-
.map(|entry| RPSRankingResponse {
23+
.map(|entry| RankingResponse {
3724
user_id: entry.user_id,
3825
count: entry.point_sum,
39-
point_sum: entry.point_sum,
4026
})
4127
.collect())
4228
}

atcoder-problems-backend/tests/test_server_e2e_rated_point_sum_ranking.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ async fn test_rated_point_sum_ranking() {
3434
assert_eq!(
3535
response,
3636
json!([
37-
{"user_id":"u2","point_sum":2,"count":2},
38-
{"user_id":"u1","point_sum":1,"count":1},
39-
{"user_id":"u3","point_sum":1,"count":1}
37+
{"user_id":"u2","count":2},
38+
{"user_id":"u1","count":1},
39+
{"user_id":"u3","count":1}
4040
])
4141
);
4242

@@ -48,8 +48,8 @@ async fn test_rated_point_sum_ranking() {
4848
assert_eq!(
4949
response,
5050
json!([
51-
{"user_id":"u1","point_sum":1,"count":1},
52-
{"user_id":"u3","point_sum":1,"count":1}
51+
{"user_id":"u1","count":1},
52+
{"user_id":"u3","count":1}
5353
])
5454
);
5555

@@ -61,7 +61,7 @@ async fn test_rated_point_sum_ranking() {
6161
assert_eq!(
6262
response,
6363
json!([
64-
{"user_id":"u2","point_sum":2,"count":2}
64+
{"user_id":"u2","count":2}
6565
])
6666
);
6767

0 commit comments

Comments
 (0)