Skip to content

Commit d248eae

Browse files
committed
fix: ksp processing error on each change
The issue arises because Kotlin's JVM name mangling (e.g., methodName$module_name) for internal members causes KSP to generate or reference names that differ from what the Dagger compiler expects, especially across different Gradle modules. Refs: #2 Link: google/dagger#4193
1 parent 1227ce9 commit d248eae

26 files changed

+26
-26
lines changed

app/src/main/java/dev/kenkoro/app/App.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import dev.kenkoro.lib.di.configureExceptionMappers
88
import dev.kenkoro.utils.LogcatAntilog
99
import io.github.aakira.napier.Napier
1010

11-
internal class App : DaggerApp() {
11+
class App : DaggerApp() {
1212
override fun onCreate() {
1313
super.onCreate()
1414
FirebaseCrashlytics.getInstance().isCrashlyticsCollectionEnabled = BuildConfig.DEBUG.not()

app/src/main/java/dev/kenkoro/app/MainActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import dev.kenkoro.app.databinding.MainActivityBinding
1313
import dev.kenkoro.app.di.NoParamsActivity
1414
import dev.kenkoro.app.utils.requireNavHostFragment
1515

16-
internal class MainActivity : NoParamsActivity() {
16+
class MainActivity : NoParamsActivity() {
1717
private lateinit var binding: MainActivityBinding
1818
private lateinit var appBarConfiguration: AppBarConfiguration
1919

app/src/main/java/dev/kenkoro/app/di/ActivityModule.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import dagger.android.ContributesAndroidInjector
55
import dev.kenkoro.app.MainActivity
66

77
@Module
8-
internal interface ActivityModule {
8+
interface ActivityModule {
99
@ContributesAndroidInjector
1010
fun contributeMainActivityAndroidInjector(): MainActivity
1111
}

app/src/main/java/dev/kenkoro/app/di/AppComponent.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import javax.inject.Singleton
2020
LibModule::class,
2121
]
2222
)
23-
internal interface AppComponent {
23+
interface AppComponent {
2424
@Component.Builder
2525
interface Builder {
2626
@BindsInstance

app/src/main/java/dev/kenkoro/app/di/DaggerActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import android.os.Bundle
44
import androidx.appcompat.app.AppCompatActivity
55
import dagger.android.AndroidInjection
66

7-
internal open class DaggerActivity : AppCompatActivity() {
7+
open class DaggerActivity : AppCompatActivity() {
88
override fun onCreate(savedInstanceState: Bundle?) {
99
AndroidInjection.inject(this)
1010
super.onCreate(savedInstanceState)

app/src/main/java/dev/kenkoro/app/di/DaggerApp.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import dagger.android.HasAndroidInjector
77
import dev.kenkoro.app.BuildConfig
88
import javax.inject.Inject
99

10-
internal open class DaggerApp : Application(), HasAndroidInjector {
10+
open class DaggerApp : Application(), HasAndroidInjector {
1111
@Inject
1212
lateinit var androidInjector: DispatchingAndroidInjector<Any>
1313

app/src/main/java/dev/kenkoro/app/di/DaggerFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import androidx.fragment.app.Fragment
99
import androidx.viewbinding.ViewBinding
1010
import dagger.android.support.AndroidSupportInjection
1111

12-
internal abstract class DaggerFragment<VB : ViewBinding> : Fragment() {
12+
abstract class DaggerFragment<VB : ViewBinding> : Fragment() {
1313
private var _binding: VB? = null
1414
protected val binding: VB
1515
get() = requireNotNull(_binding) { "Couldn't read the binding on creation" }

app/src/main/java/dev/kenkoro/app/di/FragmentModule.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import dev.kenkoro.app.feature.sample.AssistedSampleFragment
66
import dev.kenkoro.app.feature.sample.SampleFragment
77

88
@Module
9-
internal interface FragmentModule {
9+
interface FragmentModule {
1010
@ContributesAndroidInjector
1111
fun contributeSampleFragmentAndroidInjector(): SampleFragment
1212

app/src/main/java/dev/kenkoro/app/di/NoParamsActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import androidx.lifecycle.ViewModelProvider
66
import androidx.lifecycle.viewmodel.CreationExtras
77
import javax.inject.Inject
88

9-
internal open class NoParamsActivity : DaggerActivity() {
9+
open class NoParamsActivity : DaggerActivity() {
1010
@Inject
1111
lateinit var defaultFactory: ViewModelProvider.Factory
1212

app/src/main/java/dev/kenkoro/app/di/NoParamsFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import androidx.lifecycle.viewmodel.CreationExtras
77
import androidx.viewbinding.ViewBinding
88
import javax.inject.Inject
99

10-
internal abstract class NoParamsFragment<VB : ViewBinding> : DaggerFragment<VB>() {
10+
abstract class NoParamsFragment<VB : ViewBinding> : DaggerFragment<VB>() {
1111
@Inject
1212
lateinit var defaultFactory: ViewModelProvider.Factory
1313

0 commit comments

Comments
 (0)