Replies: 1 comment
-
This has been implemented in the main branch of the project now right here in this repository, so if you want this feature, get the latest (4/19/25) and you will have "half grid" as an option under "general settings". My pull request is now closed and I'm happy with the feature as implemented. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
I've been using OpenSCAD for years now and GridFinity-Rebuilt is a mainstay in my items printed. I had an older (2023-ish) version that I've been using for years (with many customizations) and with a new now computer I'm setting everything up fresh and decided to grab gridfinity-rebuilt from the GitHub repository.
I was stunned to see that base_div_x and base_div_y for (gridfinity-rebuilt-bins.scad) are no longer present. After a little digging I see how it is currently implemented to automatically calculate, but I really like my divided by 2 base no matter the size of the bin.
That is a long way to say, I've implemented a simple fix (lightly touching only 3 files (generic-helpers, to add a function), (gridfinity-rebuilt-utility.scad, to implement the base division using a new passed parameter with default value specified), and (gridfinity-rebuilt.bins.scad, to surface in the customizer the two minimum grid divisors and to add their values to the call to gridfinityBase)
I would have updated the .md files, but they seem to be out of date compared to the current code so I didn't want to do anything to them.
I don't see any docs or contributing guide in the project so...
I forked the repository into my account, I cloned my fork, made the proposed changes, tested them, then committed those files and pushed them back to my fork on gitHub.
I'm going to submit a pull-request, so I'd really appreciate some feedback. I have a few additions I think the project might benefit from and I've noticed a few feature requests I might be able to help implement solutions to also. So I hope this goes smoothly. Also, if the documentation pages should be updated to match current code (even before my changes), I'm happy to do that as well.
Thanks
Beta Was this translation helpful? Give feedback.
All reactions