fix: additional persistence fixes for semantic context

Author: kennvene-aws

crates/semantic-search-client/src/client/background/background_worker.rs

@@ -245,6 +245,7 @@ impl BackgroundWorker {
                 &context_dir,
                 &items,
                 effective_embedding_type,
+                params.persistent,
                 operation_id,
                 &cancel_token,
                 &self.operation_manager,

crates/semantic-search-client/src/client/context/context_creator.rs

@@ -44,6 +44,7 @@ impl ContextCreator {
         context_dir: &Path,
         items: &[serde_json::Value],
         embedding_type: EmbeddingType,
+        persistent: bool,
         operation_id: Uuid,
         cancel_token: &CancellationToken,
         operation_manager: &OperationManager,
@@ -54,6 +55,7 @@ impl ContextCreator {
             self.create_bm25_context(
                 context_dir,
                 items,
+                persistent,
                 operation_id,
                 cancel_token,
                 operation_manager,
@@ -64,6 +66,7 @@ impl ContextCreator {
             self.create_semantic_context(
                 context_dir,
                 items,
+                persistent,
                 operation_id,
                 cancel_token,
                 operation_manager,
@@ -78,6 +81,7 @@ impl ContextCreator {
         &self,
         context_dir: &Path,
         items: &[serde_json::Value],
+        persistent: bool,
         operation_id: Uuid,
         cancel_token: &CancellationToken,
         operation_manager: &OperationManager,
@@ -128,7 +132,10 @@ impl ContextCreator {
             .add_data_points(data_points)
             .map_err(|e| format!("Failed to add BM25 data points: {}", e))?;
 
-        let _ = bm25_context.save();
+        // Save to disk if persistent
+        if persistent {
+            let _ = bm25_context.save();
+        }
 
         // Store the BM25 context
         let context_id = context_dir
@@ -150,6 +157,7 @@ impl ContextCreator {
         &self,
         context_dir: &Path,
         items: &[serde_json::Value],
+        persistent: bool,
         operation_id: Uuid,
         cancel_token: &CancellationToken,
         operation_manager: &OperationManager,
@@ -205,8 +213,10 @@ impl ContextCreator {
             .add_data_points(data_points)
             .map_err(|e| format!("Failed to add data points: {}", e))?;
 
-        // Persist context.
-        let _ = semantic_context.save();
+        // Persist context if persistent
+        if persistent {
+            let _ = semantic_context.save();
+        }
 
         // Store the semantic context
         let context_id = context_dir

crates/semantic-search-client/src/client/context/semantic_context.rs

@@ -1,19 +1,10 @@
-use std::fs::{
-    self,
-    File,
-};
-use std::io::{
-    BufReader,
-    BufWriter,
-};
+use std::fs::{self, File};
+use std::io::{BufReader, BufWriter};
 use std::path::PathBuf;
 
 use crate::error::Result;
 use crate::index::VectorIndex;
-use crate::types::{
-    DataPoint,
-    SearchResult,
-};
+use crate::types::{DataPoint, SearchResult};
 
 /// A semantic context containing data points and a vector index
 pub struct SemanticContext {
@@ -98,9 +89,6 @@ impl SemanticContext {
         // Update the index
         self.update_index_by_range(start_idx, end_idx)?;
 
-        // Save to disk
-        self.save()?;
-
         Ok(count)
     }