Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Commit be3f6d5

Browse files
Prevent early, spurious Codecov reports (#972)
* Prevent early, spurious Codecov reports * Fix after_n_builds to be for comment instead of notify It turns out comment is for email and notify is for Slack, IRC, etc: https://docs.codecov.io/docs/notifications * Separate test and lint jobs * Move after_n_builds into tests flag * Revert commits This reverts commit 64ebab0 and everything after it. * Change codecov back to reporting after all 14 builds * Increase after_n_builds to include codecov builds itself * Address codecov comments
1 parent c346068 commit be3f6d5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

codecov.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ coverage:
55
target: auto
66
threshold: 0.03%
77
base: auto
8+
comment:
9+
after_n_builds: 14 # Prevent early, spurious Codecov reports before all tests finish: https://github.com/kensho-technologies/graphql-compiler/pull/806#issuecomment-730622647. 14 is calculated from the number of jobs to run, which is specified in the .github/workflows/tests_and_lint.yml file: 6 lint jobs (1 job per combination of python-version and lint-flags) and 8 test jobs (1 job per combination of python-version and markers).

0 commit comments

Comments
 (0)