Skip to content

Commit 139cc3b

Browse files
MaksimDrobchakstepovat
authored andcommitted
Messages_prop_is_corrected (#151)
* Messages prop is corrected * Add explicit test for passing messages
1 parent 1148417 commit 139cc3b

File tree

6 files changed

+69
-6
lines changed

6 files changed

+69
-6
lines changed

src/components/with_search.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const withSearch = WrappedComponent => ({
1212
}) => {
1313
const SearchRenderer = searchRenderer;
1414
return (
15-
<WrappedComponent {...others}>
15+
<WrappedComponent {...others} messages={messages}>
1616
{showSearch && (
1717
<SearchRenderer
1818
onChange={filterItems}

tests/components/__snapshots__/destination_list.spec.js.snap

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,13 @@ exports[`DestinationList Case disabled search with destination list 1`] = `
66
height={400}
77
itemHeight={40}
88
listRenderer={[Function]}
9-
messages={Object {}}
9+
messages={
10+
Object {
11+
"messages": Object {
12+
"searchPlaceholder": "Search",
13+
},
14+
}
15+
}
1016
noItemsRenderer={[Function]}
1117
selectedIds={Array []}
1218
selectedItemRenderer={[Function]}
@@ -21,7 +27,13 @@ exports[`DestinationList Case include search with destination list 1`] = `
2127
height={400}
2228
itemHeight={40}
2329
listRenderer={[Function]}
24-
messages={Object {}}
30+
messages={
31+
Object {
32+
"messages": Object {
33+
"searchPlaceholder": "Search",
34+
},
35+
}
36+
}
2537
noItemsRenderer={[Function]}
2638
selectedIds={Array []}
2739
selectedItemRenderer={[Function]}

tests/components/__snapshots__/multi_select.spec.js.snap

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4530,7 +4530,14 @@ Object {
45304530
"itemHeight": 40,
45314531
"itemRenderer": [Function],
45324532
"listRenderer": [Function],
4533-
"messages": Object {},
4533+
"messages": Object {
4534+
"clearAllMessage": "Uncheck all",
4535+
"noItemsMessage": "No entries available...",
4536+
"noneSelectedMessage": "Nothing",
4537+
"searchPlaceholder": "Find...",
4538+
"selectAllMessage": "Check all",
4539+
"selectedMessage": "Checked",
4540+
},
45344541
"noItemsRenderer": [Function],
45354542
"selectAllHeight": undefined,
45364543
"selectAllItems": undefined,

tests/components/__snapshots__/source_list.spec.js.snap

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,16 @@ exports[`SourceList passed source_list wrapped up to HOC withSearch 1`] = `
427427
itemHeight={10}
428428
itemRenderer={[MockFunction mockedComponent]}
429429
listRenderer={[Function]}
430-
messages={Object {}}
430+
messages={
431+
Object {
432+
"clearAllMessage": "Uncheck all",
433+
"noItemsMessage": "No entries available...",
434+
"noneSelectedMessage": "Nothing",
435+
"searchPlaceholder": "Find...",
436+
"selectAllMessage": "Check all",
437+
"selectedMessage": "Checked",
438+
}
439+
}
431440
noItemsRenderer={[Function]}
432441
selectAllHeight={60}
433442
selectAllItems={[MockFunction selectAllItems]}

tests/components/__snapshots__/with_search.spec.js.snap

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ exports[`With search Case custom search component 1`] = `
1010
},
1111
]
1212
}
13+
messages={
14+
Object {
15+
"searchPlaceholder": "Search",
16+
}
17+
}
1318
>
1419
<UserSearch
1520
onChange={[MockFunction]}
@@ -35,6 +40,11 @@ exports[`With search Case default search component 1`] = `
3540
},
3641
]
3742
}
43+
messages={
44+
Object {
45+
"searchPlaceholder": "Search",
46+
}
47+
}
3848
>
3949
<Search
4050
onChange={[MockFunction]}
@@ -50,4 +60,12 @@ exports[`With search Case default search component 1`] = `
5060
</CustomComponent>
5161
`;
5262

53-
exports[`With search Case not search component 1`] = `<CustomComponent />`;
63+
exports[`With search Case not search component 1`] = `
64+
<CustomComponent
65+
messages={
66+
Object {
67+
"searchPlaceholder": "Search",
68+
}
69+
}
70+
/>
71+
`;

tests/components/with_search.spec.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from "react";
2+
import { mount } from "enzyme";
23
import ShallowRenderer from "react-test-renderer/shallow";
34
import withSearch from "../../src/components/with_search.js";
45

@@ -60,4 +61,20 @@ describe("With search", () => {
6061
);
6162
expect(component).toMatchSnapshot();
6263
});
64+
65+
test("Case messages are passed ok", () => {
66+
const filterItems = jest.fn();
67+
const component = mount(
68+
<ListComponent
69+
showSearch={false}
70+
searchRenderer={UserSearch}
71+
searchIcon={<img src="custom_icon" alt="" />}
72+
searchValue="11"
73+
messages={messages}
74+
filterItems={filterItems}
75+
/>
76+
);
77+
const listComponent = component.find(ListComponent);
78+
expect(listComponent.props().messages).toEqual(messages);
79+
});
6380
});

0 commit comments

Comments
 (0)