Remove YOUTUBE_PLAYLIST_URL config

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

Author: cursoragent

.env.example

@@ -121,8 +121,7 @@ R2_SECRET_ACCESS_KEY=MOCK_R2_SECRET_ACCESS_KEY
 SEMANTIC_SEARCH_IGNORE_LIST_KEY=manifests/ignore-list.json
 
 # Feature: YouTube playlist semantic indexing + /youtube route
-# Optional: set either playlist URL or playlist ID.
-YOUTUBE_PLAYLIST_URL=https://www.youtube.com/watch?v=wSEUlS8WcQs&list=PLV5CVI1eNcJgNqzNwcs4UKrlJdhfDjshf
+# Optional: set playlist ID.
 YOUTUBE_PLAYLIST_ID=PLV5CVI1eNcJgNqzNwcs4UKrlJdhfDjshf
 # Optional: helps bypass YouTube anti-bot checks for captions in some envs.
 YOUTUBE_COOKIE=MOCK_YOUTUBE_COOKIE

.github/workflows/index-semantic-youtube.yml

@@ -47,10 +47,9 @@ jobs:
             ${{ secrets.CLOUDFLARE_AI_EMBEDDING_MODEL }}
           R2_BUCKET: ${{ secrets.R2_BUCKET }}
 
-          # Prefer setting one of these as repository variables.
-          # If neither is set, the script uses a built-in default playlist ID.
-          YOUTUBE_PLAYLIST_URL: ${{ vars.YOUTUBE_PLAYLIST_URL }}
-          YOUTUBE_PLAYLIST_ID: ${{ vars.YOUTUBE_PLAYLIST_ID }}
+          # Prefer setting as a repository variable (or secret).
+          # If not set, the script uses a built-in default playlist ID.
+          YOUTUBE_PLAYLIST_ID: ${{ vars.YOUTUBE_PLAYLIST_ID || secrets.YOUTUBE_PLAYLIST_ID }}
 
           # Optional: force-index specific videos. Can be set either as a
           # workflow_dispatch input or as a repository variable.

app/routes/youtube.tsx

@@ -46,8 +46,7 @@ function parsePlaylistId(value: string | undefined) {
 }
 
 export async function loader() {
-	const playlistInput =
-		process.env.YOUTUBE_PLAYLIST_URL ?? process.env.YOUTUBE_PLAYLIST_ID
+	const playlistInput = process.env.YOUTUBE_PLAYLIST_ID
 	const configuredPlaylistId =
 		parsePlaylistId(playlistInput) ?? DEFAULT_PLAYLIST_ID
 	return json({

other/semantic-search/index-youtube-playlist.ts

@@ -292,15 +292,10 @@ function collectObjectsByKey(
 	return result
 }
 
-function firstNonEmptyTrimmed(
-	...values: Array<string | undefined | null>
-): string | undefined {
-	for (const value of values) {
-		if (typeof value !== 'string') continue
-		const trimmed = value.trim()
-		if (trimmed) return trimmed
-	}
-	return undefined
+function nonEmptyTrimmed(value: string | undefined | null): string | undefined {
+	if (typeof value !== 'string') return undefined
+	const trimmed = value.trim()
+	return trimmed ? trimmed : undefined
 }
 
 /**
@@ -321,23 +316,6 @@ function getYouTubePlaylistId(input: string | undefined | null): string | null {
 	}
 }
 
-function resolveYouTubePlaylistInput({
-	playlistArg,
-	playlistUrlEnv,
-	playlistIdEnv,
-	defaultPlaylistId,
-}: {
-	playlistArg?: string | undefined
-	playlistUrlEnv?: string | undefined
-	playlistIdEnv?: string | undefined
-	defaultPlaylistId: string
-}): string {
-	return (
-		firstNonEmptyTrimmed(playlistArg, playlistUrlEnv, playlistIdEnv) ??
-		defaultPlaylistId
-	)
-}
-
 function extractYoutubeVideoId(rawUrl: string) {
 	let parsed: URL
 	try {
@@ -1229,16 +1207,14 @@ async function main() {
 		prune,
 		dryRun,
 	} = parseArgs()
-	const playlistInput = resolveYouTubePlaylistInput({
-		playlistArg,
-		playlistUrlEnv: process.env.YOUTUBE_PLAYLIST_URL,
-		playlistIdEnv: process.env.YOUTUBE_PLAYLIST_ID,
-		defaultPlaylistId: DEFAULT_PLAYLIST_ID,
-	})
+	const playlistInput =
+		nonEmptyTrimmed(playlistArg) ??
+		nonEmptyTrimmed(process.env.YOUTUBE_PLAYLIST_ID) ??
+		DEFAULT_PLAYLIST_ID
 	const playlistId = getYouTubePlaylistId(playlistInput)
 	if (!playlistId) {
 		throw new Error(
-			`Invalid YouTube playlist input: "${playlistInput}". Use --playlist with a playlist URL or ID.`,
+			`Invalid YouTube playlist input: "${playlistInput}". Use --playlist with a playlist URL or ID, or set YOUTUBE_PLAYLIST_ID.`,
 		)
 	}
 

other/semantic-search/readme.md

@@ -35,8 +35,7 @@ For podcast indexing:
 
 For YouTube playlist indexing (optional but recommended as repo variables):
 
-- `YOUTUBE_PLAYLIST_URL` (full URL with `list=...`) **or**
-- `YOUTUBE_PLAYLIST_ID` (playlist ID only)
+- `YOUTUBE_PLAYLIST_ID` (playlist ID)
 - Optional (helps when YouTube returns anti-bot `LOGIN_REQUIRED`):
   - `YOUTUBE_COOKIE` (cookie header value from a logged-in browser session)
   - `YOUTUBE_USER_AGENT`
@@ -89,8 +88,8 @@ Script:
 
 Optional flags:
 
-- `--playlist "<url-or-id>"` (defaults to `YOUTUBE_PLAYLIST_URL`,
-  `YOUTUBE_PLAYLIST_ID`, or a built-in default playlist ID)
+- `--playlist "<url-or-id>"` (defaults to `YOUTUBE_PLAYLIST_ID` or a built-in
+  default playlist ID)
 - `--max-videos 50` (helpful for staged/backfill runs)
 - `--include-auto-captions false` (manual captions only)
 - `--manifest-key manifests/youtube-my-playlist.json`