Show 404 suggestions section even when empty

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

Author: cursoragent

app/components/errors.tsx

@@ -108,7 +108,7 @@ function ErrorPage({
 				) : null}
 				<HeroSection {...resolvedHeroProps} />
 
-				{possibleMatches?.length ? (
+				{possibleMatches ? (
 					<PossibleMatchesSection
 						matches={possibleMatches}
 						query={possibleMatchesQuery}
@@ -194,7 +194,7 @@ function PossibleMatchesSection({
 						))}
 					</ul>
 					<p className="mt-4 text-sm text-slate-500">
-						{hasMatches ? 'None of these match? ' : 'No deterministic matches found. '}
+						{hasMatches ? 'None of these match? ' : 'No close matches found. '}
 						<a href={searchUrl} className="underlined">
 							Try semantic search
 						</a>

app/utils/not-found-suggestions.server.ts

@@ -472,10 +472,6 @@ export async function getNotFoundSuggestions({
 	// Keep tests fast; this can walk the repo content tree.
 	if (process.env.NODE_ENV === 'test') return null
 	if (request.method.toUpperCase() !== 'GET') return null
-	const accept = request.headers.get('accept') ?? ''
-	const wantsHtml =
-		accept.includes('text/html') || accept.includes('application/xhtml+xml')
-	if (!wantsHtml) return null
 
 	const resolvedPathname = normalizePathname(
 		typeof pathname === 'string' && pathname
@@ -519,12 +515,8 @@ export async function getNotFoundSuggestions({
 			}
 		}
 
-		if (!matches.length) return null
-		const sorted = sortNotFoundMatches(matches, { priorities }).slice(
-			0,
-			safeLimit,
-		)
-		return sorted.length ? { query, matches: sorted } : null
+		const sorted = sortNotFoundMatches(matches, { priorities }).slice(0, safeLimit)
+		return { query, matches: sorted }
 	} catch (error: unknown) {
 		// 404 pages should never fail the request because suggestions failed.
 		console.error('Deterministic 404 suggestions failed', error)