Use MSW for external password checks

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

Author: cursoragent

app/utils/password.server.ts

@@ -75,10 +75,6 @@ function getPasswordHashParts(password: string) {
 }
 
 async function checkIsCommonPassword(password: string) {
-	// In mocks mode we don't want to make external HTTP requests for password
-	// strength checks (it can hang CI / e2e test runs and adds nondeterminism).
-	if (process.env.MOCKS === 'true') return false
-
 	const [prefix, suffix] = getPasswordHashParts(password)
 	try {
 		const response = await fetchWithTimeout(

app/utils/user-info.server.ts

@@ -42,13 +42,6 @@ export async function gravatarExistsForEmail({
 		staleWhileRevalidate: 1000 * 60 * 60 * 24 * 365,
 		checkValue: (prevValue) => typeof prevValue === 'boolean',
 		getFreshValue: async (context) => {
-			// In mocks mode we should not make external HTTP requests (can hang/flake
-			// CI/e2e runs, especially with Node v24 fetch abort issues).
-			if (process.env.MOCKS === 'true') {
-				context.metadata.ttl = 1000 * 60 * 60 * 24 * 365
-				return false
-			}
-
 			const gravatarUrl = getAvatar(email, { fallback: '404' })
 			try {
 				const timeoutMs = context.background || forceFresh ? 1000 * 10 : 100

mocks/index.ts

@@ -54,8 +54,8 @@ const miscHandlers = [
 		},
 	),
 	http.head('https://www.gravatar.com/avatar/:md5Hash', async () => {
-		if (await isConnectedToTheInternet()) return passthrough()
-
+		// In mocks mode we want deterministic behavior and to avoid external HTTP
+		// requests that can flake in CI (even when DNS works).
 		return HttpResponse.json(null, { status: 404 })
 	}),
 	http.get(/http:\/\/(localhost|127\.0\.0\.1):\d+\/.*/, async () =>