Build results of c9f3ee2 (on master)

kentfredric · kentfredric · commit 749cf8a699d7 · 2012-02-04T20:35:26.000+13:00
diff --git a/.perltidyrc b/.perltidyrc
@@ -0,0 +1,2 @@
+-i 2
+-l 130
diff --git a/Build.PL b/Build.PL
@@ -23,7 +23,7 @@ my %module_build_args = (
     "Kent Fredric <kentnl\@cpan.org>"
   ],
   "dist_name" => "Dist-Zilla-Plugin-MetaProvides",
-  "dist_version" => "1.12060502",
+  "dist_version" => "1.13000000",
   "license" => "perl",
   "module_name" => "Dist::Zilla::Plugin::MetaProvides",
   "recommends" => {},
diff --git a/Changes b/Changes
@@ -1,5 +1,11 @@
 Revision history for Dist-Zilla-Plugin-MetaProvides
 
+1.13000000 2012-02-04T07:35:05Z
+ [Features]
+ - Add a provisional filter that eliminates X::_y form namespaces ( a
+   hiding convention ), enabled by default. Toggle skip_underscore to
+   change. Thanks XDG/David Golden for reporting this in rt#74675.
+
 1.12060502 2012-02-04T00:39:26Z
  - Maintenance Release
 
diff --git a/MANIFEST b/MANIFEST
@@ -1,3 +1,4 @@
+.perltidyrc
 Build.PL
 Changes
 LICENSE
diff --git a/META.json b/META.json
@@ -77,19 +77,19 @@
    "provides" : {
       "Dist::Zilla::MetaProvides::ProvideRecord" : {
          "file" : "lib/Dist/Zilla/MetaProvides/ProvideRecord.pm",
-         "version" : "1.12060502"
+         "version" : "1.13000000"
       },
       "Dist::Zilla::MetaProvides::Types" : {
          "file" : "lib/Dist/Zilla/MetaProvides/Types.pm",
-         "version" : "1.12060502"
+         "version" : "1.13000000"
       },
       "Dist::Zilla::Plugin::MetaProvides" : {
          "file" : "lib/Dist/Zilla/Plugin/MetaProvides.pm",
-         "version" : "1.12060502"
+         "version" : "1.13000000"
       },
       "Dist::Zilla::Role::MetaProvider::Provider" : {
          "file" : "lib/Dist/Zilla/Role/MetaProvider/Provider.pm",
-         "version" : "1.12060502"
+         "version" : "1.13000000"
       }
    },
    "release_status" : "stable",
@@ -101,7 +101,7 @@
          "web" : "https://github.com/kentfredric/dist-zilla-plugin-metaprovides"
       }
    },
-   "version" : "1.12060502",
+   "version" : "1.13000000",
    "x_BuiltWith" : {
       "modules" : {
          "Dist::Zilla::Plugin::Bootstrap::lib" : "0.01023601",
@@ -110,7 +110,7 @@
          "Dist::Zilla::PluginBundle::Author::KENTNL::Lite" : "NA(possibly not installed)",
          "Dist::Zilla::Role::MetaProvider" : "4.300007",
          "Dist::Zilla::Util::EmulatePhase" : "0.01025801",
-         "Dist::Zilla::Util::Test::KENTNL" : "0.01015822",
+         "Dist::Zilla::Util::Test::KENTNL" : "0.01015823",
          "File::Find" : "1.19",
          "File::Temp" : "0.22",
          "Module::Build" : "0.38",
diff --git a/META.yml b/META.yml
@@ -26,16 +26,16 @@ no_index:
 provides:
   Dist::Zilla::MetaProvides::ProvideRecord:
     file: lib/Dist/Zilla/MetaProvides/ProvideRecord.pm
-    version: 1.12060502
+    version: 1.13000000
   Dist::Zilla::MetaProvides::Types:
     file: lib/Dist/Zilla/MetaProvides/Types.pm
-    version: 1.12060502
+    version: 1.13000000
   Dist::Zilla::Plugin::MetaProvides:
     file: lib/Dist/Zilla/Plugin/MetaProvides.pm
-    version: 1.12060502
+    version: 1.13000000
   Dist::Zilla::Role::MetaProvider::Provider:
     file: lib/Dist/Zilla/Role/MetaProvider/Provider.pm
-    version: 1.12060502
+    version: 1.13000000
 requires:
   Dist::Zilla::Role::MetaProvider: 0
   Dist::Zilla::Util::EmulatePhase: 0.01000101
@@ -50,7 +50,7 @@ requires:
 resources:
   homepage: https://github.com/kentfredric/dist-zilla-plugin-metaprovides
   repository: https://github.com/kentfredric/dist-zilla-plugin-metaprovides.git
-version: 1.12060502
+version: 1.13000000
 x_BuiltWith:
   modules:
     Dist::Zilla::Plugin::Bootstrap::lib: 0.01023601
@@ -59,7 +59,7 @@ x_BuiltWith:
     Dist::Zilla::PluginBundle::Author::KENTNL::Lite: 'NA(possibly not installed)'
     Dist::Zilla::Role::MetaProvider: 4.300007
     Dist::Zilla::Util::EmulatePhase: 0.01025801
-    Dist::Zilla::Util::Test::KENTNL: 0.01015822
+    Dist::Zilla::Util::Test::KENTNL: 0.01015823
     File::Find: 1.19
     File::Temp: 0.22
     Module::Build: 0.38
diff --git a/README b/README
@@ -3,7 +3,7 @@ NAME
     in your META.yml
 
 VERSION
-    version 1.12060502
+    version 1.13000000
 
 SYNOPSIS
     In your projects dist.ini
diff --git a/lib/Dist/Zilla/MetaProvides/ProvideRecord.pm b/lib/Dist/Zilla/MetaProvides/ProvideRecord.pm
@@ -6,7 +6,7 @@ BEGIN {
   $Dist::Zilla::MetaProvides::ProvideRecord::AUTHORITY = 'cpan:KENTNL';
 }
 {
-  $Dist::Zilla::MetaProvides::ProvideRecord::VERSION = '1.12060502';
+  $Dist::Zilla::MetaProvides::ProvideRecord::VERSION = '1.13000000';
 }
 
 # ABSTRACT: Data Management Record for MetaProvider::Provides Based Class
@@ -28,7 +28,13 @@ has module => ( isa => Str, is => 'ro', required => 1 );
 has file => ( isa => Str, is => 'ro', required => 1 );
 
 
-has parent => ( is => 'ro', required => 1, weak_ref => 1, isa => ProviderObject, handles => [ 'zilla', '_resolve_version', ], );
+has parent => (
+  is       => 'ro',
+  required => 1,
+  weak_ref => 1,
+  isa      => ProviderObject,
+  handles  => [ 'zilla', '_resolve_version', ],
+);
 
 
 sub copy_into {
@@ -56,7 +62,7 @@ Dist::Zilla::MetaProvides::ProvideRecord - Data Management Record for MetaProvid
 
 =head1 VERSION
 
-version 1.12060502
+version 1.13000000
 
 =head1 ATTRIBUTES
 
diff --git a/lib/Dist/Zilla/MetaProvides/Types.pm b/lib/Dist/Zilla/MetaProvides/Types.pm
@@ -6,7 +6,7 @@ BEGIN {
   $Dist::Zilla::MetaProvides::Types::AUTHORITY = 'cpan:KENTNL';
 }
 {
-  $Dist::Zilla::MetaProvides::Types::VERSION = '1.12060502';
+  $Dist::Zilla::MetaProvides::Types::VERSION = '1.13000000';
 }
 
 # ABSTRACT: Utility Types for the MetaProvides Plugin
@@ -35,7 +35,7 @@ Dist::Zilla::MetaProvides::Types - Utility Types for the MetaProvides Plugin
 
 =head1 VERSION
 
-version 1.12060502
+version 1.13000000
 
 =head1 SUBTYPES
 
diff --git a/lib/Dist/Zilla/Plugin/MetaProvides.pm b/lib/Dist/Zilla/Plugin/MetaProvides.pm
@@ -6,7 +6,7 @@ BEGIN {
   $Dist::Zilla::Plugin::MetaProvides::AUTHORITY = 'cpan:KENTNL';
 }
 {
-  $Dist::Zilla::Plugin::MetaProvides::VERSION = '1.12060502';
+  $Dist::Zilla::Plugin::MetaProvides::VERSION = '1.13000000';
 }
 
 # ABSTRACT: Generating and Populating 'provides' in your META.yml
@@ -23,7 +23,7 @@ Dist::Zilla::Plugin::MetaProvides - Generating and Populating 'provides' in your
 
 =head1 VERSION
 
-version 1.12060502
+version 1.13000000
 
 =head1 SYNOPSIS
 
diff --git a/lib/Dist/Zilla/Role/MetaProvider/Provider.pm b/lib/Dist/Zilla/Role/MetaProvider/Provider.pm
@@ -6,7 +6,7 @@ BEGIN {
   $Dist::Zilla::Role::MetaProvider::Provider::AUTHORITY = 'cpan:KENTNL';
 }
 {
-  $Dist::Zilla::Role::MetaProvider::Provider::VERSION = '1.12060502';
+  $Dist::Zilla::Role::MetaProvider::Provider::VERSION = '1.13000000';
 }
 
 # ABSTRACT: A Role for Metadata providers specific to the 'provider' key.
@@ -48,10 +48,20 @@ has meta_noindex => (
 );
 
 
+has skip_underscore => (
+  is            => 'ro',
+  isa           => Bool,
+  default       => 1,
+  documentation => 'Skip packages with a leading _ , ie: Foo::_internal::baz',
+);
+
+
 sub _resolve_version {
   my $self    = shift;
   my $version = shift;
-  if ( $self->inherit_version or ( $self->inherit_missing and not defined $version ) ) {
+  if ( $self->inherit_version
+    or ( $self->inherit_missing and not defined $version ) )
+  {
     return ( 'version', $self->zilla->version );
   }
   if ( not defined $version ) {
@@ -98,17 +108,17 @@ sub _apply_meta_noindex {
   $packages   = $noindex->{'package'}   if exists $noindex->{'package'};
   $namespaces = $noindex->{'namespace'} if exists $noindex->{'namespace'};
 
-  for my $file (@{$files}) {
+  for my $file ( @{$files} ) {
     @items = grep { $_->file ne $file } @items;
   }
-  for my $module (@{$packages}) {
+  for my $module ( @{$packages} ) {
     @items = grep { $_->module ne $module } @items;
   }
-  for my $dir (@{$dirs}) {
+  for my $dir ( @{$dirs} ) {
     ## no critic (RegularExpressions ProhibitPunctuationVars)
     @items = grep { $_->file !~ qr{^\Q$dir\E($|/)} } @items;
   }
-  for my $namespace (@{$namespaces}) {
+  for my $namespace ( @{$namespaces} ) {
     ## no critic (RegularExpressions ProhibitPunctuationVars)
     @items = grep { $_->module !~ qr{^\Q$namespace\E($|::)} } @items;
   }
@@ -120,6 +130,10 @@ sub metadata {
   my ($self) = @_;
   my $discover = {};
   for ( $self->provides ) {
+    if ( $self->skip_underscore and $_->module =~ /(\A_|::_)/msx ) {
+      $self->log_debug( 'Skipping ' . $_->module . ' due to /skip_underscore = true ' );
+      next;
+    }
     $_->copy_into($discover);
   }
   return { provides => $discover };
@@ -140,7 +154,7 @@ Dist::Zilla::Role::MetaProvider::Provider - A Role for Metadata providers specif
 
 =head1 VERSION
 
-version 1.12060502
+version 1.13000000
 
 =head1 PERFORMS ROLES
 
@@ -213,6 +227,28 @@ to not be provided in the metadata.
 
 =back
 
+=head2 skip_underscore
+
+Filter out detected namespaces with a token with a leading C<_>, ie:
+
+    Foo::Bar::_internal::Baz;
+
+This is a convenience to provide sane defaults. For more controlled exclusion of namespaces, see L<Dist::Zilla::Plugin::MetaNoIndex>
+
+=head3 values
+
+=over 4
+
+=item * Set to "0"
+
+I<underscore>'d namespaces will be included.
+
+=item * Set to "1" B<[default]>
+
+I<underscore>'d namespaces will not be included.
+
+=back
+
 =head1 PRIVATE METHODS
 
 =head2 _resolve_version
diff --git a/t/lib/Dist/Zilla/Plugin/FakePlugin.pm b/t/lib/Dist/Zilla/Plugin/FakePlugin.pm
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-package # PAUSE
+package    # PAUSE
   Dist::Zilla::Plugin::FakePlugin;
 
 use Moose;
@@ -12,10 +12,10 @@ with 'Dist::Zilla::Role::MetaProvider::Provider';
 sub provides {
   my $self = shift;
   return Dist::Zilla::MetaProvides::ProvideRecord->new(
-    module => 'FakeModule',
-    file => 'C:\temp\notevenonwindows.pl',
+    module  => 'FakeModule',
+    file    => 'C:\temp\notevenonwindows.pl',
     version => '3.1414',
-    parent => $self,
+    parent  => $self,
   );
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+.perltidyrc`
`1`	`2`	`Build.PL`
`2`	`3`	`Changes`
`3`	`4`	`LICENSE`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ BEGIN {`
`6`	`6`	`$Dist::Zilla::MetaProvides::Types::AUTHORITY = 'cpan:KENTNL';`
`7`	`7`	`}`
`8`	`8`	`{`
`9`		`- $Dist::Zilla::MetaProvides::Types::VERSION = '1.12060502';`
	`9`	`+ $Dist::Zilla::MetaProvides::Types::VERSION = '1.13000000';`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`# ABSTRACT: Utility Types for the MetaProvides Plugin`
`@@ -35,7 +35,7 @@ Dist::Zilla::MetaProvides::Types - Utility Types for the MetaProvides Plugin`
`35`	`35`
`36`	`36`	`=head1 VERSION`
`37`	`37`
`38`		`-version 1.12060502`
	`38`	`+version 1.13000000`
`39`	`39`
`40`	`40`	`=head1 SUBTYPES`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ BEGIN {`
`6`	`6`	`$Dist::Zilla::Plugin::MetaProvides::AUTHORITY = 'cpan:KENTNL';`
`7`	`7`	`}`
`8`	`8`	`{`
`9`		`- $Dist::Zilla::Plugin::MetaProvides::VERSION = '1.12060502';`
	`9`	`+ $Dist::Zilla::Plugin::MetaProvides::VERSION = '1.13000000';`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`# ABSTRACT: Generating and Populating 'provides' in your META.yml`
`@@ -23,7 +23,7 @@ Dist::Zilla::Plugin::MetaProvides - Generating and Populating 'provides' in your`
`23`	`23`
`24`	`24`	`=head1 VERSION`
`25`	`25`
`26`		`-version 1.12060502`
	`26`	`+version 1.13000000`
`27`	`27`
`28`	`28`	`=head1 SYNOPSIS`
`29`	`29`