Skip to content

Commit 4befa17

Browse files
committed
potential fix for issues with geoarrow in point and line layers
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
1 parent 6a86082 commit 4befa17

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

src/deckgl-layers/src/deckgl-extensions/filter-arrow-layer.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,8 @@ export default class FilterArrowExtension extends LayerExtension {
4242
filtered: {
4343
size: 1,
4444
type: 'float32',
45-
accessor: 'getFiltered',
46-
shaderAttributes: {
47-
filtered: {
48-
divisor: 0
49-
},
50-
instanceFiltered: {
51-
divisor: 1
52-
}
53-
}
45+
stepMode: 'dynamic',
46+
accessor: 'getFiltered'
5447
}
5548
});
5649
}

src/deckgl-layers/src/deckgl-extensions/filter-shader-module.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,14 @@
44
import {project} from '@deck.gl/core';
55

66
const vs = `
7-
#ifdef NON_INSTANCED_MODEL
8-
#define FILTER_ARROW_ATTRIB filtered
9-
#else
10-
#define FILTER_ARROW_ATTRIB instanceFiltered
11-
#endif
12-
in float FILTER_ARROW_ATTRIB;
7+
in float filtered;
138
`;
149

1510
const fs = ``;
1611

1712
const inject = {
18-
// create degenerate vertices in vertex shader instead of discarding pixels in the fragment shader.
1913
'vs:#main-start': `
20-
if (FILTER_ARROW_ATTRIB == 0.) {
14+
if (filtered == 0.) {
2115
gl_Position = vec4(0.0, 0.0, 0.0, 1.0);
2216
return;
2317
}

0 commit comments

Comments
 (0)