effects disable

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>

Author: igorDykhta

src/effects/package.json

@@ -36,6 +36,7 @@
     "@kepler.gl/types": "3.2.5",
     "@kepler.gl/utils": "3.2.5",
     "@luma.gl/core": "^9.2.0",
+    "@luma.gl/effects": "^9.2.5",
     "@luma.gl/shadertools": "^9.2.0",
     "moment-timezone": "^0.5.35",
     "suncalc": "^1.9.0"

src/effects/src/post-processing-effect.ts

@@ -1,28 +1,24 @@
 // SPDX-License-Identifier: MIT
 // Copyright contributors to the kepler.gl project
 
-// @ts-nocheck - luma.gl 9.x has completely restructured shader modules
-// TODO: Refactor to use luma.gl 9.x shader module patterns
-
 import {PostProcessEffect as DeckPostProcessEffect} from '@deck.gl/core';
-
-// In luma.gl 9.x, these shader modules have been restructured
-// For now, use empty placeholders
-const brightnessContrast = {};
-const ink = {};
-const triangleBlur = {};
-const hueSaturation = {};
-const vibrance = {};
-const colorHalftone = {};
-const dotScreen = {};
-const edgeWork = {};
-const noise = {};
-const sepia = {};
-const tiltShift = {};
-const vignette = {};
-const zoomBlur = {};
-const magnify = {};
-const hexagonalPixelate = {};
+import {
+  brightnessContrast,
+  ink,
+  triangleBlur,
+  hueSaturation,
+  vibrance,
+  colorHalftone,
+  dotScreen,
+  edgeWork,
+  noise,
+  sepia,
+  tiltShift,
+  vignette,
+  zoomBlur,
+  magnify,
+  hexagonalPixelate
+} from '@luma.gl/effects';
 
 import {POSTPROCESSING_EFFECTS, DEFAULT_POST_PROCESSING_EFFECT_TYPE} from '@kepler.gl/constants';
 import {EffectPropsPartial, EffectParameterDescription} from '@kepler.gl/types';
@@ -118,20 +114,28 @@ class PostProcessingEffect extends Effect {
 
   _initializeEffect() {
     const effectDesc = POSTPROCESSING_EFFECTS_DESCS.find(desc => desc.type === this.type);
-    if (effectDesc) {
-      this.deckEffect = new DeckPostProcessEffect(effectDesc.class, this.parameters);
+    if (effectDesc && effectDesc.class) {
+      try {
+        this.deckEffect = new DeckPostProcessEffect(effectDesc.class, this.parameters);
 
-      const uniforms = this.deckEffect?.module?.uniforms;
-      if (uniforms) {
-        // get default parameters
-        const keys = Object.keys(uniforms);
-        const defaultParameters = {};
-        keys.forEach(key => {
-          defaultParameters[key] = getDefaultValueForParameter(key, this._uiConfig, uniforms);
-        });
-        this.parameters = {...defaultParameters, ...this.parameters};
-        this.deckEffect?.setProps(this.parameters);
+        const uniforms = this.deckEffect?.module?.uniforms;
+        if (uniforms) {
+          // get default parameters
+          const keys = Object.keys(uniforms);
+          const defaultParameters = {};
+          keys.forEach(key => {
+            defaultParameters[key] = getDefaultValueForParameter(key, this._uiConfig, uniforms);
+          });
+          this.parameters = {...defaultParameters, ...this.parameters};
+          this.deckEffect?.setProps(this.parameters);
+        }
+      } catch (error) {
+        console.warn(`Failed to initialize post-processing effect "${this.type}":`, error);
+        this.deckEffect = null;
       }
+    } else {
+      console.warn(`Post-processing effect "${this.type}" is not properly configured`);
+      this.deckEffect = null;
     }
   }
 
@@ -143,8 +147,8 @@ class PostProcessingEffect extends Effect {
     super.setProps(props);
 
     // any uniform updated?
-    if (props.parameters) {
-      this.deckEffect?.setProps(this.parameters);
+    if (props.parameters && this.deckEffect) {
+      this.deckEffect.setProps(this.parameters);
     }
   }
 }

yarn.lock

@@ -5202,6 +5202,7 @@ __metadata:
     "@kepler.gl/types": "npm:3.2.5"
     "@kepler.gl/utils": "npm:3.2.5"
     "@luma.gl/core": "npm:^9.2.0"
+    "@luma.gl/effects": "npm:^9.2.5"
     "@luma.gl/shadertools": "npm:^9.2.0"
     moment-timezone: "npm:^0.5.35"
     suncalc: "npm:^1.9.0"
@@ -6102,6 +6103,19 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@luma.gl/effects@npm:^9.2.5":
+  version: 9.2.5
+  resolution: "@luma.gl/effects@npm:9.2.5"
+  dependencies:
+    "@math.gl/core": "npm:^4.1.0"
+    "@math.gl/types": "npm:^4.1.0"
+    wgsl_reflect: "npm:^1.0.1"
+  peerDependencies:
+    "@luma.gl/shadertools": ~9.2.0
+  checksum: 10c0/0c62eda62ea1242ae273ef85abfe508a75e2b30e81174d5c567e80ee965972d323428a7469b74c6c38a852fd86c9497ada08d4b981a820fb8ba30d140984506e
+  languageName: node
+  linkType: hard
+
 "@luma.gl/engine@npm:9.2.4":
   version: 9.2.4
   resolution: "@luma.gl/engine@npm:9.2.4"
@@ -31680,7 +31694,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"wgsl_reflect@npm:^1.2.0":
+"wgsl_reflect@npm:^1.0.1, wgsl_reflect@npm:^1.2.0":
   version: 1.2.3
   resolution: "wgsl_reflect@npm:1.2.3"
   checksum: 10c0/0ac66a98607a606ea0d9c419de9be63137ab0cbe05a9024f65fe3d606de1ab40d5b6a50a8fc30b8ad5b06dc7d676e7e5f6c4218ce0061f2b4a17d3722ca363b4