Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

Commit 0fc8c36

Browse files
authored
fix: Use NetworkingV1 instead of deprecated ExtensionsV1beta1 (#492)
Fixes keptn/keptn#4432 Signed-off-by: Nitanshu Vashistha <nitanshu.vzard@gmail.com>
1 parent 8369229 commit 0fc8c36

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

pkg/common/kubeutils/endpoint_provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func NewKeptnEndpointProvider(useInClusterConfig bool) (*KeptnEndpointProvider,
2424

2525
// GetKeptnEndpointFromIngress returns the host of ingress object Keptn Installation
2626
func (a *KeptnEndpointProvider) GetKeptnEndpointFromIngress(ctx context.Context, namespace string, ingressName string) (string, error) {
27-
keptnIngress, err := a.clientSet.ExtensionsV1beta1().Ingresses(namespace).Get(ctx, ingressName, metav1.GetOptions{})
27+
keptnIngress, err := a.clientSet.NetworkingV1().Ingresses(namespace).Get(ctx, ingressName, metav1.GetOptions{})
2828
if err != nil {
2929
return "", err
3030
}

pkg/common/kubeutils/endpoint_provider_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77

88
"github.com/stretchr/testify/require"
99
v1 "k8s.io/api/core/v1"
10-
"k8s.io/api/extensions/v1beta1"
10+
networkingv1 "k8s.io/api/networking/v1"
1111
"k8s.io/apimachinery/pkg/runtime"
1212
"k8s.io/client-go/kubernetes/fake"
1313
k8stesting "k8s.io/client-go/testing"
@@ -28,7 +28,7 @@ func TestKeptnEndpointProvider_GetKeptnEndpointFromIngress_FailClientSet(t *test
2828
func TestKeptnEndpointProvider_GetKeptnEndpointFromIngress_Invalid(t *testing.T) {
2929
kubernetes := fake.NewSimpleClientset()
3030
kubernetes.Fake.PrependReactor("get", "ingresses", func(action k8stesting.Action) (handled bool, ret runtime.Object, err error) {
31-
return true, &v1beta1.Ingress{Spec: v1beta1.IngressSpec{}}, nil
31+
return true, &networkingv1.Ingress{Spec: networkingv1.IngressSpec{}}, nil
3232
})
3333
keptnEndpointProvider := &KeptnEndpointProvider{clientSet: kubernetes}
3434
res, err := keptnEndpointProvider.GetKeptnEndpointFromIngress(context.TODO(), "keptn", "ingress")
@@ -40,9 +40,9 @@ func TestKeptnEndpointProvider_GetKeptnEndpointFromIngress_Invalid(t *testing.T)
4040
func TestKeptnEndpointProvider_GetKeptnEndpointFromIngress_Valid(t *testing.T) {
4141
kubernetes := fake.NewSimpleClientset()
4242
kubernetes.Fake.PrependReactor("get", "ingresses", func(action k8stesting.Action) (handled bool, ret runtime.Object, err error) {
43-
return true, &v1beta1.Ingress{
44-
Spec: v1beta1.IngressSpec{
45-
Rules: []v1beta1.IngressRule{
43+
return true, &networkingv1.Ingress{
44+
Spec: networkingv1.IngressSpec{
45+
Rules: []networkingv1.IngressRule{
4646
{
4747
Host: "1.1.1.1",
4848
},

0 commit comments

Comments
 (0)