Skip to content

[*.py] Use f-strings and os.path.join throughout #21343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 21, 2025
Merged

[*.py] Use f-strings and os.path.join throughout #21343

merged 10 commits into from
Aug 21, 2025

Conversation

SamuelMarks
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.44444% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.99%. Comparing base (7da416d) to head (dff423a).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/applications/efficientnet_v2.py 70.00% 3 Missing ⚠️
keras/src/applications/convnext.py 75.00% 2 Missing ⚠️
keras/src/applications/inception_v3.py 0.00% 2 Missing ⚠️
keras/src/datasets/cifar100.py 0.00% 2 Missing ⚠️
keras/src/utils/file_utils.py 75.00% 2 Missing ⚠️
keras/src/utils/progbar.py 60.00% 2 Missing ⚠️
keras/src/applications/mobilenet_v3.py 80.00% 1 Missing ⚠️
keras/src/backend/openvino/numpy.py 0.00% 1 Missing ⚠️
keras/src/callbacks/model_checkpoint.py 0.00% 1 Missing ⚠️
keras/src/datasets/cifar10.py 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21343      +/-   ##
==========================================
+ Coverage   76.94%   84.99%   +8.04%     
==========================================
  Files         568      568              
  Lines       56895    56905      +10     
  Branches     8889     8890       +1     
==========================================
+ Hits        43780    48365    +4585     
+ Misses      10862     6230    -4632     
- Partials     2253     2310      +57
Flag Coverage Δ
keras 84.80% <84.44%> (+8.01%) ⬆️
keras-jax 65.96% <82.96%> (+2.30%) ⬆️
keras-numpy 58.39% <39.25%> (+0.14%) ⬆️
keras-openvino 34.68% <18.51%> (+0.13%) ⬆️
keras-tensorflow 66.52% <83.70%> (?)
keras-torch 66.09% <82.22%> (+2.28%) ⬆️
keras.applications 83.60% <88.88%> (?)
keras.applications-jax 83.60% <88.88%> (?)
keras.applications-numpy 22.81% <5.55%> (?)
keras.applications-openvino 22.81% <5.55%> (?)
keras.applications-tensorflow 83.60% <88.88%> (?)
keras.applications-torch 83.33% <88.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned added this to PR Queue Jun 5, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue Jun 5, 2025
@gbaned gbaned requested a review from fchollet June 5, 2025 05:02
@hertschuh
Copy link
Collaborator

@SamuelMarks

Thank you for this PR!

Can you rebase it? It looks like some files need merging (and sorry for taking so long to look at it).

@SamuelMarks
Copy link
Contributor Author

@hertschuh updated

@hertschuh
Copy link
Collaborator

The code needs to be reformatted it looks like, please see this section: https://github.com/keras-team/keras/blob/master/CONTRIBUTING.md#generating-public-api-and-formatting-the-code

@SamuelMarks
Copy link
Contributor Author

@hertschuh Done

@hertschuh
Copy link
Collaborator

@hertschuh Done

Still failing, it's actually the api_gen hook.

Can you try pre-commit run --all-files and then git diff to see what's going on?

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 21, 2025
@github-project-automation github-project-automation bot moved this from Assigned Reviewer to Approved by Reviewer in PR Queue Aug 21, 2025
@hertschuh hertschuh merged commit bf85450 into keras-team:master Aug 21, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Approved by Reviewer to Merged in PR Queue Aug 21, 2025
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Aug 21, 2025
@hertschuh
Copy link
Collaborator

Thanks a lot @SamuelMarks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hertschuh hertschuh hertschuh approved these changes

@fchollet fchollet Awaiting requested review from fchollet

Assignees

@gbaned gbaned

Labels
size:L
Projects
PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SamuelMarks @codecov-commenter @hertschuh @kokoro-team @gbaned