perf: maybe_foldable_expr

Author: kermanx

crates/jsshaker/src/folding/mod.rs

@@ -3,7 +3,11 @@ mod dep;
 use std::mem;
 
 use dep::{FoldableDep, UnFoldableDep};
-use oxc::{allocator, ast::ast::Expression, span::GetSpan};
+use oxc::{
+  allocator,
+  ast::{ast::Expression, match_member_expression},
+  span::GetSpan,
+};
 use rustc_hash::FxHashMap;
 
 use crate::{
@@ -112,3 +116,53 @@ impl<'a> Transformer<'a> {
     if let FoldingData::Foldable { literal, .. } = data { Some(*literal) } else { None }
   }
 }
+
+pub fn maybe_foldable_expr(node: &Expression) -> bool {
+  match node {
+    match_member_expression!(Expression) => true,
+
+    Expression::StringLiteral(_)
+    | Expression::NumericLiteral(_)
+    | Expression::BigIntLiteral(_)
+    | Expression::BooleanLiteral(_)
+    | Expression::NullLiteral(_)
+    | Expression::RegExpLiteral(_)
+    | Expression::TemplateLiteral(_) => false,
+
+    Expression::FunctionExpression(_)
+    | Expression::ArrowFunctionExpression(_)
+    | Expression::ObjectExpression(_)
+    | Expression::ParenthesizedExpression(_)
+    | Expression::SequenceExpression(_)
+    | Expression::ImportExpression(_)
+    | Expression::NewExpression(_)
+    | Expression::ClassExpression(_) => false,
+
+    Expression::Identifier(_)
+    | Expression::UnaryExpression(_)
+    | Expression::UpdateExpression(_)
+    | Expression::BinaryExpression(_)
+    | Expression::LogicalExpression(_)
+    | Expression::ConditionalExpression(_)
+    | Expression::CallExpression(_)
+    | Expression::TaggedTemplateExpression(_)
+    | Expression::AwaitExpression(_)
+    | Expression::YieldExpression(_)
+    | Expression::ArrayExpression(_)
+    | Expression::AssignmentExpression(_)
+    | Expression::ChainExpression(_)
+    | Expression::MetaProperty(_)
+    | Expression::PrivateInExpression(_)
+    | Expression::ThisExpression(_)
+    | Expression::Super(_) => true,
+
+    Expression::JSXElement(_) | Expression::JSXFragment(_) => true,
+
+    Expression::V8IntrinsicExpression(_)
+    | Expression::TSAsExpression(_)
+    | Expression::TSInstantiationExpression(_)
+    | Expression::TSTypeAssertion(_)
+    | Expression::TSNonNullExpression(_)
+    | Expression::TSSatisfiesExpression(_) => unreachable!(),
+  }
+}

crates/jsshaker/src/nodes/expr/mod.rs

@@ -31,8 +31,8 @@ use oxc::{
 use oxc_syntax::operator::{AssignmentOperator, UnaryOperator};
 
 use crate::{
-  analyzer::Analyzer, build_effect, dep::DepTrait, entity::Entity, transformer::Transformer,
-  utils::ast::AstKind2,
+  analyzer::Analyzer, build_effect, dep::DepTrait, entity::Entity, folding::maybe_foldable_expr,
+  transformer::Transformer, utils::ast::AstKind2,
 };
 
 impl<'a> Analyzer<'a> {
@@ -86,7 +86,11 @@ impl<'a> Analyzer<'a> {
       | Expression::TSSatisfiesExpression(_) => unreachable!(),
     };
     self.pop_span();
-    self.try_fold_node(AstKind2::Expression(node), value)
+    if maybe_foldable_expr(node) {
+      self.try_fold_node(AstKind2::Expression(node), value)
+    } else {
+      value
+    }
   }
 
   pub fn exec_expression_with_dependency(