Skip to content

Commit 0396a87

Browse files
juhosglinusw
authored andcommitted
pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output()
The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: Gabor Juhos <[email protected]> Link: https://lore.kernel.org/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent e6ebd49 commit 0396a87

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -432,9 +432,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip,
432432
reg = OUTPUT_EN;
433433
armada_37xx_update_reg(&reg, &en_offset);
434434

435-
regmap_update_bits(info->regmap, reg, mask, mask);
436-
437-
return 0;
435+
return regmap_update_bits(info->regmap, reg, mask, mask);
438436
}
439437

440438
static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset)

0 commit comments

Comments
 (0)