Skip to content

Commit 0539c5e

Browse files
ShuichengLinlucasdemarchi
authored andcommitted
drm/xe/pm: Correct comment of xe_pm_set_vram_threshold()
The parameter threshold is with size in MiB, not in bits. Correct it to avoid any confusion. v2: s/mb/MiB, s/vram/VRAM, fix return section. (Michal) Fixes: 30c3995 ("drm/xe: Document Xe PM component") Cc: Michal Wajdeczko <[email protected]> Cc: Rodrigo Vivi <[email protected]> Signed-off-by: Shuicheng Lin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Stuart Summers <[email protected]> Signed-off-by: Rodrigo Vivi <[email protected]> (cherry picked from commit 0efec05) Signed-off-by: Lucas De Marchi <[email protected]>
1 parent 253a174 commit 0539c5e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

drivers/gpu/drm/xe/xe_pm.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -752,11 +752,13 @@ void xe_pm_assert_unbounded_bridge(struct xe_device *xe)
752752
}
753753

754754
/**
755-
* xe_pm_set_vram_threshold - Set a vram threshold for allowing/blocking D3Cold
755+
* xe_pm_set_vram_threshold - Set a VRAM threshold for allowing/blocking D3Cold
756756
* @xe: xe device instance
757-
* @threshold: VRAM size in bites for the D3cold threshold
757+
* @threshold: VRAM size in MiB for the D3cold threshold
758758
*
759-
* Returns 0 for success, negative error code otherwise.
759+
* Return:
760+
* * 0 - success
761+
* * -EINVAL - invalid argument
760762
*/
761763
int xe_pm_set_vram_threshold(struct xe_device *xe, u32 threshold)
762764
{

0 commit comments

Comments
 (0)