Skip to content

Commit 056d76f

Browse files
sresuperna9999
authored andcommitted
drm/panel: sitronix-st7789v: fix sync flags for t28cp45tn89
I planned to set the polarity of horizontal and vertical sync, but accidentally described vertical sync twice with different polarity instead. Note, that there is no functional change, because the driver only makes use of DRM_MODE_FLAG_P[HV]SYNC to divert from the default active-low polarity. Reported-by: Laurent Pinchart <[email protected]> Closes: https://lore.kernel.org/all/[email protected]/ Fixes: a411558 ("drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support") Reviewed-by: Laurent Pinchart <[email protected]> Reviewed-by: Marek Vasut <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]> Signed-off-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 9e8b320 commit 056d76f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/gpu/drm/panel/panel-sitronix-st7789v.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,11 @@ static const struct drm_display_mode default_mode = {
249249
.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
250250
};
251251

252+
/*
253+
* The mode data for this panel has been reverse engineered without access
254+
* to the panel datasheet / manual. Using DRM_MODE_FLAG_PHSYNC like all
255+
* other panels results in garbage data on the display.
256+
*/
252257
static const struct drm_display_mode t28cp45tn89_mode = {
253258
.clock = 6008,
254259
.hdisplay = 240,
@@ -261,7 +266,7 @@ static const struct drm_display_mode t28cp45tn89_mode = {
261266
.vtotal = 320 + 8 + 4 + 4,
262267
.width_mm = 43,
263268
.height_mm = 57,
264-
.flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC,
269+
.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC,
265270
};
266271

267272
static const struct drm_display_mode et028013dma_mode = {

0 commit comments

Comments
 (0)