Skip to content

Commit 07caaf8

Browse files
committed
netlink: specs: ethtool: replace underscores with dashes in names
We're trying to add a strict regexp for the name format in the spec. Underscores will not be allowed, dashes should be used instead. This makes no difference to C (codegen replaces special chars in names) but gives more uniform naming in Python. Fixes: 13e5934 ("net: ethtool: add support for symmetric-xor RSS hash") Fixes: 46fb3ba ("ethtool: Add an interface for flashing transceiver modules' firmware") Reviewed-by: Kory Maincent <[email protected]> Reviewed-by: Donald Hunter <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 791a9ed commit 07caaf8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Documentation/netlink/specs/ethtool.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ definitions:
4848
name: started
4949
doc: The firmware flashing process has started.
5050
-
51-
name: in_progress
51+
name: in-progress
5252
doc: The firmware flashing process is in progress.
5353
-
5454
name: completed
@@ -1422,7 +1422,7 @@ attribute-sets:
14221422
name: hkey
14231423
type: binary
14241424
-
1425-
name: input_xfrm
1425+
name: input-xfrm
14261426
type: u32
14271427
-
14281428
name: start-context
@@ -2238,7 +2238,7 @@ operations:
22382238
- hfunc
22392239
- indir
22402240
- hkey
2241-
- input_xfrm
2241+
- input-xfrm
22422242
dump:
22432243
request:
22442244
attributes:

tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_rss_input_xfrm(cfg, ipver):
3838
raise KsftSkipEx("socket.SO_INCOMING_CPU was added in Python 3.11")
3939

4040
input_xfrm = cfg.ethnl.rss_get(
41-
{'header': {'dev-name': cfg.ifname}}).get('input_xfrm')
41+
{'header': {'dev-name': cfg.ifname}}).get('input-xfrm')
4242

4343
# Check for symmetric xor/or-xor
4444
if not input_xfrm or (input_xfrm != 1 and input_xfrm != 2):

0 commit comments

Comments
 (0)