mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe()

Dan Carpenter · cminyard · commit 0892507f4a0b · 2025-10-03T10:38:17.000-05:00
The devm_kzalloc() function returns NULL on error so check for that instead of error pointers. Fixes: d952bba ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Message-ID: <df80c6d61229eb8f877c3694525c0f97e64a43e8.1759478975.git.dan.carpenter@linaro.org> Signed-off-by: Corey Minyard <corey@minyard.net>
diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c
@@ -469,7 +469,7 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const struct pci_device_id *id)
 		return ret;
 
 	ddata = devm_kzalloc(&dev->dev, sizeof(*ddata), GFP_KERNEL);
-	if (IS_ERR(ddata)) {
+	if (!ddata) {
 		ret = -ENOMEM;
 		goto disable_pci;
 	}

Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ static int ls2k_bmc_probe(struct pci_dev dev, const struct pci_device_id id)`
`469`	`469`	`return ret;`
`470`	`470`
`471`	`471`	`ddata = devm_kzalloc(&dev->dev, sizeof(*ddata), GFP_KERNEL);`
`472`		`- if (IS_ERR(ddata)) {`
	`472`	`+ if (!ddata) {`
`473`	`473`	`ret = -ENOMEM;`
`474`	`474`	`goto disable_pci;`
`475`	`475`	`}`