Skip to content

Commit 0d51077

Browse files
jonhunteralexandrebelloni
authored andcommitted
Revert "rtc: cpcap: Fix initial enable_irq/disable_irq balance"
Commit e0762fd ("rtc: cpcap: Fix initial enable_irq/disable_irq balance") set 'alarm_enabled' prior to calling the function devm_request_threaded_irq() because this enables the IRQ. However, right after calling devm_request_threaded_irq(), the driver calls disable_irq() to disable the IRQ and so now 'alarm_enabled' will be true but the IRQ is actually disabled. Revert this commit to fix the 'alarm_enabled' state. Fixes: e0762fd ("rtc: cpcap: Fix initial enable_irq/disable_irq balance") Signed-off-by: Jon Hunter <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent b1c9390 commit 0d51077

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/rtc/rtc-cpcap.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
268268
return err;
269269

270270
rtc->alarm_irq = platform_get_irq(pdev, 0);
271-
rtc->alarm_enabled = true;
272271
err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
273272
cpcap_rtc_alarm_irq,
274273
IRQF_TRIGGER_NONE | IRQF_ONESHOT,

0 commit comments

Comments
 (0)