Skip to content

Commit 0efec05

Browse files
ShuichengLinrodrigovivi
authored andcommitted
drm/xe/pm: Correct comment of xe_pm_set_vram_threshold()
The parameter threshold is with size in MiB, not in bits. Correct it to avoid any confusion. v2: s/mb/MiB, s/vram/VRAM, fix return section. (Michal) Fixes: 30c3995 ("drm/xe: Document Xe PM component") Cc: Michal Wajdeczko <[email protected]> Cc: Rodrigo Vivi <[email protected]> Signed-off-by: Shuicheng Lin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Stuart Summers <[email protected]> Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent 1d2e250 commit 0efec05

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

drivers/gpu/drm/xe/xe_pm.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -761,11 +761,13 @@ void xe_pm_assert_unbounded_bridge(struct xe_device *xe)
761761
}
762762

763763
/**
764-
* xe_pm_set_vram_threshold - Set a vram threshold for allowing/blocking D3Cold
764+
* xe_pm_set_vram_threshold - Set a VRAM threshold for allowing/blocking D3Cold
765765
* @xe: xe device instance
766-
* @threshold: VRAM size in bites for the D3cold threshold
766+
* @threshold: VRAM size in MiB for the D3cold threshold
767767
*
768-
* Returns 0 for success, negative error code otherwise.
768+
* Return:
769+
* * 0 - success
770+
* * -EINVAL - invalid argument
769771
*/
770772
int xe_pm_set_vram_threshold(struct xe_device *xe, u32 threshold)
771773
{

0 commit comments

Comments
 (0)