Skip to content

Commit 0f860ee

Browse files
jimmyhonmmind
authored andcommitted
arm64: dts: rockchip: Fix the headphone detection on the orangepi 5
The logic of the headphone detect pin seems to be inverted, with this change headphones actually output sound when plugged in. Does not need workaround of using pin-switches to enable output. Verified by checking /sys/kernel/debug/gpio. Fixes: ae46756 ("arm64: dts: rockchip: analog audio on Orange Pi 5") Signed-off-by: Jimmy Hon <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 41194ee commit 0f860ee

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@
4242
simple-audio-card,bitclock-master = <&masterdai>;
4343
simple-audio-card,format = "i2s";
4444
simple-audio-card,frame-master = <&masterdai>;
45-
simple-audio-card,hp-det-gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
45+
simple-audio-card,hp-det-gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_HIGH>;
4646
simple-audio-card,mclk-fs = <256>;
47-
simple-audio-card,pin-switches = "Headphones";
4847
simple-audio-card,routing =
4948
"Headphones", "LOUT1",
5049
"Headphones", "ROUT1",

0 commit comments

Comments
 (0)