Skip to content

Commit 169c9d0

Browse files
committed
Merge tag 'linux-watchdog-6.18-rc1' of git://www.linux-watchdog.org/linux-watchdog
Pull watchdog updates from Wim Van Sebroeck: - renesas,wdt: Add support for RZ/T2H and RZ/N2H - Add SMARC-sAM67 support - Several small fixes and improvements * tag 'linux-watchdog-6.18-rc1' of git://www.linux-watchdog.org/linux-watchdog: watchdog/hpwdt New maintianer dt-bindings: watchdog: add SMARC-sAM67 support watchdog: mpc8xxx_wdt: Reload the watchdog timer when enabling the watchdog watchdog: visconti: don't print superfluous errors watchdog: rzv2h_wdt: don't print superfluous errors watchdog: rzg2l_wdt: don't print superfluous errors watchdog: s3c2410_wdt: exynosautov9: Enable supported features watchdog: s3c2410_wdt: exynosautov920: Enable QUIRK_HAS_32BIT_CNT watchdog: s3c2410_wdt: Increase max timeout value of watchdog watchdog: s3c2410_wdt: Fix max_timeout being calculated larger watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions watchdog: rzv2h: Improve error strings and add newlines watchdog: rzv2h: Add support for RZ/T2H watchdog: rzv2h: Add support for configurable count clock source watchdog: rzv2h: Make "oscclk" and reset controller optional watchdog: rzv2h: Obtain clock-divider and timeout values from OF match data dt-bindings: watchdog: renesas,wdt: Add support for RZ/T2H and RZ/N2H watchdog: intel_oc_wdt: Do not try to write into const memory
2 parents 2f2c725 + c64c2a5 commit 169c9d0

File tree

8 files changed

+206
-47
lines changed

8 files changed

+206
-47
lines changed

Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml

Lines changed: 33 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,17 @@ properties:
8181
- renesas,r9a09g056-wdt # RZ/V2N
8282
- const: renesas,r9a09g057-wdt # RZ/V2H(P)
8383

84-
- const: renesas,r9a09g057-wdt # RZ/V2H(P)
84+
- enum:
85+
- renesas,r9a09g057-wdt # RZ/V2H(P)
86+
- renesas,r9a09g077-wdt # RZ/T2H
87+
88+
- items:
89+
- const: renesas,r9a09g087-wdt # RZ/N2H
90+
- const: renesas,r9a09g077-wdt # RZ/T2H
8591

8692
reg:
87-
maxItems: 1
93+
minItems: 1
94+
maxItems: 2
8895

8996
interrupts:
9097
minItems: 1
@@ -132,6 +139,7 @@ allOf:
132139
compatible:
133140
contains:
134141
enum:
142+
- renesas,r9a09g077-wdt
135143
- renesas,rza-wdt
136144
- renesas,rzn1-wdt
137145
then:
@@ -183,7 +191,9 @@ allOf:
183191
properties:
184192
compatible:
185193
contains:
186-
const: renesas,r9a09g057-wdt
194+
enum:
195+
- renesas,r9a09g057-wdt
196+
- renesas,r9a09g077-wdt
187197
then:
188198
properties:
189199
interrupts: false
@@ -192,6 +202,26 @@ allOf:
192202
required:
193203
- interrupts
194204

205+
- if:
206+
properties:
207+
compatible:
208+
contains:
209+
const: renesas,r9a09g077-wdt
210+
then:
211+
properties:
212+
resets: false
213+
clock-names:
214+
maxItems: 1
215+
reg:
216+
minItems: 2
217+
required:
218+
- clock-names
219+
- power-domains
220+
else:
221+
properties:
222+
reg:
223+
maxItems: 1
224+
195225
additionalProperties: false
196226

197227
examples:

MAINTAINERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10961,7 +10961,7 @@ S: Supported
1096110961
F: drivers/misc/hpilo.[ch]
1096210962

1096310963
HEWLETT PACKARD ENTERPRISE ILO NMI WATCHDOG DRIVER
10964-
M: Jerry Hoemann <jerry.hoemann@hpe.com>
10964+
M: Craig Lamparter <craig.lamparter@hpe.com>
1096510965
S: Supported
1096610966
F: Documentation/watchdog/hpwdt.rst
1096710967
F: drivers/watchdog/hpwdt.c

drivers/watchdog/intel_oc_wdt.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
struct intel_oc_wdt {
4242
struct watchdog_device wdd;
4343
struct resource *ctrl_res;
44+
struct watchdog_info info;
4445
bool locked;
4546
};
4647

@@ -115,7 +116,6 @@ static const struct watchdog_ops intel_oc_wdt_ops = {
115116

116117
static int intel_oc_wdt_setup(struct intel_oc_wdt *oc_wdt)
117118
{
118-
struct watchdog_info *info;
119119
unsigned long val;
120120

121121
val = inl(INTEL_OC_WDT_CTRL_REG(oc_wdt));
@@ -134,7 +134,6 @@ static int intel_oc_wdt_setup(struct intel_oc_wdt *oc_wdt)
134134
set_bit(WDOG_HW_RUNNING, &oc_wdt->wdd.status);
135135

136136
if (oc_wdt->locked) {
137-
info = (struct watchdog_info *)&intel_oc_wdt_info;
138137
/*
139138
* Set nowayout unconditionally as we cannot stop
140139
* the watchdog.
@@ -145,7 +144,7 @@ static int intel_oc_wdt_setup(struct intel_oc_wdt *oc_wdt)
145144
* and inform the core we can't change it.
146145
*/
147146
oc_wdt->wdd.timeout = (val & INTEL_OC_WDT_TOV) + 1;
148-
info->options &= ~WDIOF_SETTIMEOUT;
147+
oc_wdt->info.options &= ~WDIOF_SETTIMEOUT;
149148

150149
dev_info(oc_wdt->wdd.parent,
151150
"Register access locked, heartbeat fixed at: %u s\n",
@@ -193,7 +192,8 @@ static int intel_oc_wdt_probe(struct platform_device *pdev)
193192
wdd->min_timeout = INTEL_OC_WDT_MIN_TOV;
194193
wdd->max_timeout = INTEL_OC_WDT_MAX_TOV;
195194
wdd->timeout = INTEL_OC_WDT_DEF_TOV;
196-
wdd->info = &intel_oc_wdt_info;
195+
oc_wdt->info = intel_oc_wdt_info;
196+
wdd->info = &oc_wdt->info;
197197
wdd->ops = &intel_oc_wdt_ops;
198198
wdd->parent = dev;
199199

drivers/watchdog/mpc8xxx_wdt.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ static int mpc8xxx_wdt_start(struct watchdog_device *w)
100100
ddata->swtc = tmp >> 16;
101101
set_bit(WDOG_HW_RUNNING, &ddata->wdd.status);
102102

103+
mpc8xxx_wdt_keepalive(ddata);
104+
103105
return 0;
104106
}
105107

drivers/watchdog/rzg2l_wdt.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -310,9 +310,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev)
310310
watchdog_set_nowayout(&priv->wdev, nowayout);
311311
watchdog_stop_on_unregister(&priv->wdev);
312312

313-
ret = watchdog_init_timeout(&priv->wdev, 0, dev);
314-
if (ret)
315-
dev_warn(dev, "Specified timeout invalid, using default");
313+
watchdog_init_timeout(&priv->wdev, 0, dev);
316314

317315
return devm_watchdog_register_device(&pdev->dev, &priv->wdev);
318316
}

0 commit comments

Comments
 (0)