Skip to content

Commit 1a69c63

Browse files
Hans ZhangMani-Sadhasivam
authored andcommitted
PCI: rockchip: Remove redundant PCIe message routing definitions
The Rockchip driver contains duplicated message routing and INTx code definitions (e.g., ROCKCHIP_PCIE_MSG_ROUTING_TO_RC, ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTA). These are already provided by the PCI core in drivers/pci/pci.h as PCIE_MSG_TYPE_R_RC and PCIE_MSG_CODE_ASSERT_INTA, respectively. Remove the driver-specific definitions in favor of the core definitions instead. This aligns the driver with the PCIe specification and reduces maintenance overhead. Signed-off-by: Hans Zhang <[email protected]> [mani: commit message rewording] Signed-off-by: Manivannan Sadhasivam <[email protected]> Link: https://patch.msgid.link/[email protected]
1 parent 19272b3 commit 1a69c63

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

drivers/pci/controller/pcie-rockchip.h

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -215,20 +215,6 @@
215215
#define RC_REGION_0_TYPE_MASK GENMASK(3, 0)
216216
#define MAX_AXI_WRAPPER_REGION_NUM 33
217217

218-
#define ROCKCHIP_PCIE_MSG_ROUTING_TO_RC 0x0
219-
#define ROCKCHIP_PCIE_MSG_ROUTING_VIA_ADDR 0x1
220-
#define ROCKCHIP_PCIE_MSG_ROUTING_VIA_ID 0x2
221-
#define ROCKCHIP_PCIE_MSG_ROUTING_BROADCAST 0x3
222-
#define ROCKCHIP_PCIE_MSG_ROUTING_LOCAL_INTX 0x4
223-
#define ROCKCHIP_PCIE_MSG_ROUTING_PME_ACK 0x5
224-
#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTA 0x20
225-
#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTB 0x21
226-
#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTC 0x22
227-
#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTD 0x23
228-
#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTA 0x24
229-
#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTB 0x25
230-
#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTC 0x26
231-
#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTD 0x27
232218
#define ROCKCHIP_PCIE_MSG_ROUTING_MASK GENMASK(7, 5)
233219
#define ROCKCHIP_PCIE_MSG_ROUTING(route) \
234220
(((route) << 5) & ROCKCHIP_PCIE_MSG_ROUTING_MASK)

0 commit comments

Comments
 (0)