Skip to content

Commit 1c05bf6

Browse files
hvilleneuvedoogregkh
authored andcommitted
serial: sc16is7xx: remove useless enable of enhanced features
Commit 43c51bb ("sc16is7xx: make sure device is in suspend once probed") permanently enabled access to the enhanced features in sc16is7xx_probe(), and it is never disabled after that. Therefore, remove re-enable of enhanced features in sc16is7xx_set_baud(). This eliminates a potential useless read + write cycle each time the baud rate is reconfigured. Fixes: 43c51bb ("sc16is7xx: make sure device is in suspend once probed") Cc: stable <[email protected]> Signed-off-by: Hugo Villeneuve <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e7cbce7 commit 1c05bf6

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/tty/serial/sc16is7xx.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -588,13 +588,6 @@ static int sc16is7xx_set_baud(struct uart_port *port, int baud)
588588
div /= prescaler;
589589
}
590590

591-
/* Enable enhanced features */
592-
sc16is7xx_efr_lock(port);
593-
sc16is7xx_port_update(port, SC16IS7XX_EFR_REG,
594-
SC16IS7XX_EFR_ENABLE_BIT,
595-
SC16IS7XX_EFR_ENABLE_BIT);
596-
sc16is7xx_efr_unlock(port);
597-
598591
/* If bit MCR_CLKSEL is set, the divide by 4 prescaler is activated. */
599592
sc16is7xx_port_update(port, SC16IS7XX_MCR_REG,
600593
SC16IS7XX_MCR_CLKSEL_BIT,

0 commit comments

Comments
 (0)