Skip to content

Commit 1f65c86

Browse files
WOnder93Kernel Patches Daemon
authored andcommitted
bpf, arm64: Do not audit capability check in do_jit()
Analogically to the x86 commit 881a9c9 ("bpf: Do not audit capability check in do_jit()"), change the capable() call to ns_capable_noaudit() in order to avoid spurious SELinux denials in audit log. The commit log from that commit applies here as well: """ The failure of this check only results in a security mitigation being applied, slightly affecting performance of the compiled BPF program. It doesn't result in a failed syscall, an thus auditing a failed LSM permission check for it is unwanted. For example with SELinux, it causes a denial to be reported for confined processes running as root, which tends to be flagged as a problem to be fixed in the policy. Yet dontauditing or allowing CAP_SYS_ADMIN to the domain may not be desirable, as it would allow/silence also other checks - either going against the principle of least privilege or making debugging potentially harder. Fix it by changing it from capable() to ns_capable_noaudit(), which instructs the LSMs to not audit the resulting denials. """ Fixes: f300769 ("arm64: bpf: Only mitigate cBPF programs loaded by unprivileged users") Signed-off-by: Ondrej Mosnacek <[email protected]>
1 parent 3ea267d commit 1f65c86

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm64/net/bpf_jit_comp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1004,7 +1004,7 @@ static void __maybe_unused build_bhb_mitigation(struct jit_ctx *ctx)
10041004
arm64_get_spectre_v2_state() == SPECTRE_VULNERABLE)
10051005
return;
10061006

1007-
if (capable(CAP_SYS_ADMIN))
1007+
if (ns_capable_noaudit(&init_user_ns, CAP_SYS_ADMIN))
10081008
return;
10091009

10101010
if (supports_clearbhb(SCOPE_SYSTEM)) {

0 commit comments

Comments
 (0)