Skip to content

Commit 203817d

Browse files
isilenceaxboe
authored andcommitted
io_uring/zcrx: fix pp destruction warnings
With multiple page pools and in some other cases we can have allocated niovs on page pool destruction. Remove a misplaced warning checking that all niovs are returned to zcrx on io_pp_zc_destroy(). It was reported before but apparently got lost. Reported-by: Pedro Tammela <[email protected]> Fixes: 34a3e60 ("io_uring/zcrx: implement zerocopy receive pp memory provider") Signed-off-by: Pavel Begunkov <[email protected]> Link: https://lore.kernel.org/r/b9e6d919d2964bc48ddbf8eb52fc9f5d118e9bc1.1751878185.git.asml.silence@gmail.com Signed-off-by: Jens Axboe <[email protected]>
1 parent 6f11adc commit 203817d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

io_uring/zcrx.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -862,10 +862,7 @@ static int io_pp_zc_init(struct page_pool *pp)
862862
static void io_pp_zc_destroy(struct page_pool *pp)
863863
{
864864
struct io_zcrx_ifq *ifq = io_pp_to_ifq(pp);
865-
struct io_zcrx_area *area = ifq->area;
866865

867-
if (WARN_ON_ONCE(area->free_count != area->nia.num_niovs))
868-
return;
869866
percpu_ref_put(&ifq->ctx->refs);
870867
}
871868

0 commit comments

Comments
 (0)