Skip to content

Commit 2453753

Browse files
Sakari Ailussre
authored andcommitted
power: supply: bq24190: Remove redundant pm_runtime_mark_last_busy() calls
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), pm_runtime_autosuspend() and pm_request_autosuspend() now include a call to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to pm_runtime_mark_last_busy(). Signed-off-by: Sakari Ailus <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sebastian Reichel <[email protected]>
1 parent 61b8c39 commit 2453753

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

drivers/power/supply/bq24190_charger.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,6 @@ static ssize_t bq24190_sysfs_show(struct device *dev,
504504
else
505505
count = sysfs_emit(buf, "%hhx\n", v);
506506

507-
pm_runtime_mark_last_busy(bdi->dev);
508507
pm_runtime_put_autosuspend(bdi->dev);
509508

510509
return count;
@@ -535,7 +534,6 @@ static ssize_t bq24190_sysfs_store(struct device *dev,
535534
if (ret)
536535
count = ret;
537536

538-
pm_runtime_mark_last_busy(bdi->dev);
539537
pm_runtime_put_autosuspend(bdi->dev);
540538

541539
return count;
@@ -562,7 +560,6 @@ static int bq24190_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable)
562560
else
563561
ret = bq24190_charger_set_charge_type(bdi, &val);
564562

565-
pm_runtime_mark_last_busy(bdi->dev);
566563
pm_runtime_put_autosuspend(bdi->dev);
567564

568565
return ret;
@@ -605,7 +602,6 @@ static int bq24296_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable)
605602
}
606603

607604
out:
608-
pm_runtime_mark_last_busy(bdi->dev);
609605
pm_runtime_put_autosuspend(bdi->dev);
610606

611607
return ret;
@@ -638,7 +634,6 @@ static int bq24190_vbus_is_enabled(struct regulator_dev *dev)
638634
BQ24190_REG_POC_CHG_CONFIG_MASK,
639635
BQ24190_REG_POC_CHG_CONFIG_SHIFT, &val);
640636

641-
pm_runtime_mark_last_busy(bdi->dev);
642637
pm_runtime_put_autosuspend(bdi->dev);
643638

644639
if (ret)
@@ -675,7 +670,6 @@ static int bq24296_vbus_is_enabled(struct regulator_dev *dev)
675670
BQ24296_REG_POC_OTG_CONFIG_MASK,
676671
BQ24296_REG_POC_OTG_CONFIG_SHIFT, &val);
677672

678-
pm_runtime_mark_last_busy(bdi->dev);
679673
pm_runtime_put_autosuspend(bdi->dev);
680674

681675
if (ret)
@@ -1376,7 +1370,6 @@ static int bq24190_charger_get_property(struct power_supply *psy,
13761370
ret = -ENODATA;
13771371
}
13781372

1379-
pm_runtime_mark_last_busy(bdi->dev);
13801373
pm_runtime_put_autosuspend(bdi->dev);
13811374

13821375
return ret;
@@ -1419,7 +1412,6 @@ static int bq24190_charger_set_property(struct power_supply *psy,
14191412
ret = -EINVAL;
14201413
}
14211414

1422-
pm_runtime_mark_last_busy(bdi->dev);
14231415
pm_runtime_put_autosuspend(bdi->dev);
14241416

14251417
return ret;
@@ -1682,7 +1674,6 @@ static int bq24190_battery_get_property(struct power_supply *psy,
16821674
ret = -ENODATA;
16831675
}
16841676

1685-
pm_runtime_mark_last_busy(bdi->dev);
16861677
pm_runtime_put_autosuspend(bdi->dev);
16871678

16881679
return ret;
@@ -1713,7 +1704,6 @@ static int bq24190_battery_set_property(struct power_supply *psy,
17131704
ret = -EINVAL;
17141705
}
17151706

1716-
pm_runtime_mark_last_busy(bdi->dev);
17171707
pm_runtime_put_autosuspend(bdi->dev);
17181708

17191709
return ret;
@@ -1861,7 +1851,6 @@ static irqreturn_t bq24190_irq_handler_thread(int irq, void *data)
18611851
return IRQ_NONE;
18621852
}
18631853
bq24190_check_status(bdi);
1864-
pm_runtime_mark_last_busy(bdi->dev);
18651854
pm_runtime_put_autosuspend(bdi->dev);
18661855
bdi->irq_event = false;
18671856

@@ -2188,7 +2177,6 @@ static int bq24190_probe(struct i2c_client *client)
21882177

21892178
enable_irq_wake(client->irq);
21902179

2191-
pm_runtime_mark_last_busy(dev);
21922180
pm_runtime_put_autosuspend(dev);
21932181

21942182
return 0;
@@ -2275,7 +2263,6 @@ static __maybe_unused int bq24190_pm_suspend(struct device *dev)
22752263
bq24190_register_reset(bdi);
22762264

22772265
if (error >= 0) {
2278-
pm_runtime_mark_last_busy(bdi->dev);
22792266
pm_runtime_put_autosuspend(bdi->dev);
22802267
}
22812268

@@ -2300,7 +2287,6 @@ static __maybe_unused int bq24190_pm_resume(struct device *dev)
23002287
bq24190_read(bdi, BQ24190_REG_SS, &bdi->ss_reg);
23012288

23022289
if (error >= 0) {
2303-
pm_runtime_mark_last_busy(bdi->dev);
23042290
pm_runtime_put_autosuspend(bdi->dev);
23052291
}
23062292

0 commit comments

Comments
 (0)