Skip to content

Commit 25facba

Browse files
geraldogvinodkoul
authored andcommitted
phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal
pcie_conf is used to touch TEST_WRITE strobe signal. This signal should be enabled, a little time waited, and then disabled. Current code clearly was copy-pasted and never disables the strobe signal. Adjust the define. While at it, remove PHY_CFG_RD_MASK which has been unused since 64cdc03 ("phy: rockchip-pcie: remove unused phy_rd_cfg function"). Reviewed-by: Neil Armstrong <[email protected]> Signed-off-by: Geraldo Nascimento <[email protected]> Link: https://lore.kernel.org/r/d514d5d5627680caafa8b7548cbdfee4307f5440.1751322015.git.geraldogabriel@gmail.com Signed-off-by: Vinod Koul <[email protected]>
1 parent c3fe707 commit 25facba

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/phy/rockchip/phy-rockchip-pcie.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@
3030
#define PHY_CFG_ADDR_SHIFT 1
3131
#define PHY_CFG_DATA_MASK 0xf
3232
#define PHY_CFG_ADDR_MASK 0x3f
33-
#define PHY_CFG_RD_MASK 0x3ff
3433
#define PHY_CFG_WR_ENABLE 1
35-
#define PHY_CFG_WR_DISABLE 1
34+
#define PHY_CFG_WR_DISABLE 0
3635
#define PHY_CFG_WR_SHIFT 0
3736
#define PHY_CFG_WR_MASK 1
3837
#define PHY_CFG_PLL_LOCK 0x10

0 commit comments

Comments
 (0)