Skip to content

Commit 281326b

Browse files
rabarabp3tk0v
authored andcommitted
EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection
The current single-bit error injection mechanism flips bits directly in ECC RAM by performing write and read operations. When the ECC RAM is actively used by the Ethernet or USB controller, this approach sometimes trigger a false double-bit error. Switch both Ethernet and USB EDAC devices to use the INTTEST register (altr_edac_a10_device_inject_fops) for single-bit error injection, similar to the existing double-bit error injection method. Fixes: 064acbd ("EDAC, altera: Add Stratix10 peripheral support") Signed-off-by: Niravkumar L Rabara <[email protected]> Signed-off-by: Borislav Petkov (AMD) <[email protected]> Acked-by: Dinh Nguyen <[email protected]> Cc: [email protected] Link: https://patch.msgid.link/[email protected]
1 parent fd3ecda commit 281326b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/edac/altera_edac.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1369,7 +1369,7 @@ static const struct edac_device_prv_data a10_enetecc_data = {
13691369
.ue_set_mask = ALTR_A10_ECC_TDERRA,
13701370
.set_err_ofst = ALTR_A10_ECC_INTTEST_OFST,
13711371
.ecc_irq_handler = altr_edac_a10_ecc_irq,
1372-
.inject_fops = &altr_edac_a10_device_inject2_fops,
1372+
.inject_fops = &altr_edac_a10_device_inject_fops,
13731373
};
13741374

13751375
#endif /* CONFIG_EDAC_ALTERA_ETHERNET */
@@ -1459,7 +1459,7 @@ static const struct edac_device_prv_data a10_usbecc_data = {
14591459
.ue_set_mask = ALTR_A10_ECC_TDERRA,
14601460
.set_err_ofst = ALTR_A10_ECC_INTTEST_OFST,
14611461
.ecc_irq_handler = altr_edac_a10_ecc_irq,
1462-
.inject_fops = &altr_edac_a10_device_inject2_fops,
1462+
.inject_fops = &altr_edac_a10_device_inject_fops,
14631463
};
14641464

14651465
#endif /* CONFIG_EDAC_ALTERA_USB */

0 commit comments

Comments
 (0)