Skip to content

Commit 2ab3ba3

Browse files
t-8chdaeinki
authored andcommitted
drm/bridge: samsung-dsim: Don't use %pK through printk
In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log. Since commit ad67b74 ("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used through printk(). They can still unintentionally leak raw pointers or acquire sleeping locks in atomic contexts. Switch to the regular pointer formatting which is safer and easier to reason about. Signed-off-by: Thomas Weißschuh <[email protected]> Signed-off-by: Inki Dae <[email protected]>
1 parent fd03f82 commit 2ab3ba3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/bridge/samsung-dsim.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,7 +1095,7 @@ static void samsung_dsim_send_to_fifo(struct samsung_dsim *dsi,
10951095
bool first = !xfer->tx_done;
10961096
u32 reg;
10971097

1098-
dev_dbg(dev, "< xfer %pK: tx len %u, done %u, rx len %u, done %u\n",
1098+
dev_dbg(dev, "< xfer %p: tx len %u, done %u, rx len %u, done %u\n",
10991099
xfer, length, xfer->tx_done, xfer->rx_len, xfer->rx_done);
11001100

11011101
if (length > DSI_TX_FIFO_SIZE)
@@ -1293,7 +1293,7 @@ static bool samsung_dsim_transfer_finish(struct samsung_dsim *dsi)
12931293
spin_unlock_irqrestore(&dsi->transfer_lock, flags);
12941294

12951295
dev_dbg(dsi->dev,
1296-
"> xfer %pK, tx_len %zu, tx_done %u, rx_len %u, rx_done %u\n",
1296+
"> xfer %p, tx_len %zu, tx_done %u, rx_len %u, rx_done %u\n",
12971297
xfer, xfer->packet.payload_length, xfer->tx_done, xfer->rx_len,
12981298
xfer->rx_done);
12991299

0 commit comments

Comments
 (0)