Skip to content

Commit 2af8ff1

Browse files
Florian Westphalkuba-moo
authored andcommitted
net: Kconfig: discourage drop_monitor enablement
Quoting Eric Dumazet: "I do not understand the fascination with net/core/drop_monitor.c [..] misses all the features, flexibility, scalability that 'perf', eBPF tracing, bpftrace, .... have today." Reword DROP_MONITOR kconfig help text to clearly state that its not related to perf-based drop monitoring and that its safe to disable this unless support for the older netlink-based tools is needed. Signed-off-by: Florian Westphal <[email protected]> Reviewed-by: Simon Horman <[email protected]> Reviewed-by: Eric Dumazet <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 38f3cd3 commit 2af8ff1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

net/Kconfig

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -400,15 +400,15 @@ config NET_PKTGEN
400400
module will be called pktgen.
401401

402402
config NET_DROP_MONITOR
403-
tristate "Network packet drop alerting service"
403+
tristate "Legacy network packet drop alerting service"
404404
depends on INET && TRACEPOINTS
405405
help
406406
This feature provides an alerting service to userspace in the
407407
event that packets are discarded in the network stack. Alerts
408408
are broadcast via netlink socket to any listening user space
409-
process. If you don't need network drop alerts, or if you are ok
410-
just checking the various proc files and other utilities for
411-
drop statistics, say N here.
409+
process. This feature is NOT related to "perf" based drop monitoring.
410+
Say N here unless you need to support older userspace tools like
411+
"dropwatch".
412412

413413
endmenu # Network testing
414414

0 commit comments

Comments
 (0)