Skip to content

Commit 304c102

Browse files
krzkvinodkoul
authored andcommitted
phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
Add missing DP PHY status and VCO clock configuration registers to fix configuring the VCO rate on SM8750. Without proper VCO rate setting, it works on after-reset half of rate which is not enough for DP over USB to work as seen on logs: [drm:msm_dp_ctrl_link_train_1_2] *ERROR* max v_level reached [drm:msm_dp_ctrl_link_train_1_2] *ERROR* link training #1 on phy 0 failed. ret=-11 Fixes: c436404 ("phy: qcom: qmp-combo: Add new PHY sequences for SM8750") Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 2bff908 commit 304c102

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-combo.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,9 @@ static const unsigned int qmp_v8_usb3phy_regs_layout[QPHY_LAYOUT_SIZE] = {
228228
[QPHY_COM_CMN_STATUS] = QSERDES_V8_COM_CMN_STATUS,
229229
[QPHY_COM_BIAS_EN_CLKBUFLR_EN] = QSERDES_V8_COM_BIAS_EN_CLKBUFLR_EN,
230230

231+
[QPHY_DP_PHY_STATUS] = QSERDES_V6_DP_PHY_STATUS,
232+
[QPHY_DP_PHY_VCO_DIV] = QSERDES_V6_DP_PHY_VCO_DIV,
233+
231234
[QPHY_TX_TX_POL_INV] = QSERDES_V8_TX_TX_POL_INV,
232235
[QPHY_TX_TX_DRV_LVL] = QSERDES_V8_TX_TX_DRV_LVL,
233236
[QPHY_TX_TX_EMP_POST1_LVL] = QSERDES_V8_TX_TX_EMP_POST1_LVL,

0 commit comments

Comments
 (0)