Skip to content

Commit 309fdb1

Browse files
AlexiousLudavem330
authored andcommitted
ethernet: atheros: fix a memleak in atl1e_setup_ring_resources
In the error handling of 'offset > adapter->ring_size', the tx_ring->tx_buffer allocated by kzalloc should be freed, instead of 'goto failed' instantly. Fixes: a6a5325 ("atl1e: Atheros L1E Gigabit Ethernet driver") Signed-off-by: Zhipeng Lu <[email protected]> Reviewed-by: Suman Ghosh <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 19391a2 commit 309fdb1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/atheros/atl1e/atl1e_main.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,10 +866,13 @@ static int atl1e_setup_ring_resources(struct atl1e_adapter *adapter)
866866
netdev_err(adapter->netdev, "offset(%d) > ring size(%d) !!\n",
867867
offset, adapter->ring_size);
868868
err = -1;
869-
goto failed;
869+
goto free_buffer;
870870
}
871871

872872
return 0;
873+
free_buffer:
874+
kfree(tx_ring->tx_buffer);
875+
tx_ring->tx_buffer = NULL;
873876
failed:
874877
if (adapter->ring_vir_addr != NULL) {
875878
dma_free_coherent(&pdev->dev, adapter->ring_size,

0 commit comments

Comments
 (0)