Skip to content

Commit 32ce6b3

Browse files
committed
NFSD: Avoid corruption of a referring call list
The new code neglects to remove a freshly-allocated RCL from the callback's referring call list when no matching referring call is found. Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Closes: https://lore.kernel.org/r/[email protected]/ Fixes: 4f3c8d8 ("NFSD: Implement CB_SEQUENCE referring call lists") Reviewed-by: Jeff Layton <[email protected]> Signed-off-by: Chuck Lever <[email protected]>
1 parent 425364d commit 32ce6b3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

fs/nfsd/nfs4callback.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1409,6 +1409,7 @@ void nfsd41_cb_referring_call(struct nfsd4_callback *cb,
14091409
out:
14101410
if (!rcl->__nr_referring_calls) {
14111411
cb->cb_nr_referring_call_list--;
1412+
list_del(&rcl->__list);
14121413
kfree(rcl);
14131414
}
14141415
}

0 commit comments

Comments
 (0)