bcachefs: Fix rcu imbalance in bch2_fs_btree_key_cache_exit()

Kent Overstreet · Kent Overstreet · commit 3539880ef1a5 · 2025-02-06T22:35:11.000-05:00
Spotted by sparse.

Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/btree_key_cache.c b/fs/bcachefs/btree_key_cache.c
@@ -748,7 +748,6 @@ void bch2_fs_btree_key_cache_exit(struct btree_key_cache *bc)
 				rcu_read_unlock();
 				mutex_lock(&bc->table.mutex);
 				mutex_unlock(&bc->table.mutex);
-				rcu_read_lock();
 				continue;
 			}
 			for (i = 0; i < tbl->size; i++)

Original file line number	Diff line number	Diff line change
`@@ -748,7 +748,6 @@ void bch2_fs_btree_key_cache_exit(struct btree_key_cache *bc)`
`748`	`748`	`rcu_read_unlock();`
`749`	`749`	`mutex_lock(&bc->table.mutex);`
`750`	`750`	`mutex_unlock(&bc->table.mutex);`
`751`		`- rcu_read_lock();`
`752`	`751`	`continue;`
`753`	`752`	`}`
`754`	`753`	`for (i = 0; i < tbl->size; i++)`