Skip to content

Commit 35f5b36

Browse files
Junhao Hewilldeacon
authored andcommitted
drivers/perf: hisi: Relax the event number check of v2 PMUs
The supported event number range of each Uncore PMUs is provided by each driver in hisi_pmu::check_event and out of range events will be rejected. A later version with expanded event number range needs to register the PMU with updated hisi_pmu::check_event even if it's the only update, which means the expanded events cannot be used unless the driver's updated. However the unsupported events won't be counted by the hardware so we can relax the event number check to allow the use the expanded events. Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: Junhao He <[email protected]> Signed-off-by: Yicong Yang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 1fd20ba commit 35f5b36

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
#define DDRC_V1_PERF_CTRL_EN 0x2
5454
#define DDRC_V2_PERF_CTRL_EN 0x1
5555
#define DDRC_V1_NR_EVENTS 0x7
56-
#define DDRC_V2_NR_EVENTS 0x90
56+
#define DDRC_V2_NR_EVENTS 0xFF
5757

5858
#define DDRC_EVENT_CNTn(base, n) ((base) + (n) * 8)
5959
#define DDRC_EVENT_TYPEn(base, n) ((base) + (n) * 4)

drivers/perf/hisilicon/hisi_uncore_hha_pmu.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@
4747
#define HHA_SRCID_CMD GENMASK(16, 6)
4848
#define HHA_SRCID_MSK GENMASK(30, 20)
4949
#define HHA_DATSRC_SKT_EN BIT(23)
50-
#define HHA_EVTYPE_NONE 0xff
50+
#define HHA_EVTYPE_MASK GENMASK(7, 0)
5151
#define HHA_V1_NR_EVENT 0x65
52-
#define HHA_V2_NR_EVENT 0xCE
52+
#define HHA_V2_NR_EVENT 0xFF
5353

5454
HISI_PMU_EVENT_ATTR_EXTRACTOR(srcid_cmd, config1, 10, 0);
5555
HISI_PMU_EVENT_ATTR_EXTRACTOR(srcid_msk, config1, 21, 11);
@@ -197,7 +197,7 @@ static void hisi_hha_pmu_write_evtype(struct hisi_pmu *hha_pmu, int idx,
197197

198198
/* Write event code to HHA_EVENT_TYPEx register */
199199
val = readl(hha_pmu->base + reg);
200-
val &= ~(HHA_EVTYPE_NONE << shift);
200+
val &= ~(HHA_EVTYPE_MASK << shift);
201201
val |= (type << shift);
202202
writel(val, hha_pmu->base + reg);
203203
}

drivers/perf/hisilicon/hisi_uncore_pa_pmu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ static int hisi_pa_pmu_dev_probe(struct platform_device *pdev,
440440
pa_pmu->pmu_events.attr_groups = pa_pmu->dev_info->attr_groups;
441441
pa_pmu->num_counters = PA_NR_COUNTERS;
442442
pa_pmu->ops = &hisi_uncore_pa_ops;
443-
pa_pmu->check_event = 0xB0;
443+
pa_pmu->check_event = PA_EVTYPE_MASK;
444444
pa_pmu->counter_bits = 64;
445445
pa_pmu->dev = &pdev->dev;
446446
pa_pmu->on_cpu = -1;

drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
#define SLLC_V3_SRCID_CMD_SHIFT 1
5959
#define SLLC_V3_SRCID_MSK_SHIFT 10
6060

61-
#define SLLC_NR_EVENTS 0x80
61+
#define SLLC_NR_EVENTS 0xff
6262
#define SLLC_EVENT_CNTn(cnt0, n) ((cnt0) + (n) * 8)
6363

6464
HISI_PMU_EVENT_ATTR_EXTRACTOR(tgtid_min, config1, 10, 0);

0 commit comments

Comments
 (0)